Tests added for components I worked on #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ara225
reviewed
Mar 10, 2024
|
|
||
| details.forEach((detail, index) => { | ||
| expect(listItems[index]).toHaveTextContent(detail); | ||
| }); |
There was a problem hiding this comment.
Glad to see some tests showing up here. These look great :)
Ara225
reviewed
Mar 10, 2024
| checkInDate={book.checkInDate} | ||
| checkOutDate={book.checkOutDate} | ||
| stayNights={stayNightsTotal} | ||
| /> |
There was a problem hiding this comment.
This is a matter of personal prefecence to an extent but, I would personally just give the whole book object to TableBody so it can do what it needs to do
There was a problem hiding this comment.
I will try to look this up after main tickets are done
Ara225
reviewed
Mar 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.