NW6 | nazanin_Saedi | Feature-sort-table-column | reactProject | Week4 #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for react-module-project-nw6-team-2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
added 4 commits
March 20, 2024 22:48
Ara225
reviewed
Mar 22, 2024
| direction = 'descending'; | ||
| } | ||
| setSortConfig({ key, direction }); | ||
| }; |
There was a problem hiding this comment.
Looking good, like how you support sorting in both directions
|
|
||
|
|
||
| // Sorting function based on the current sort configuration | ||
| const sortedBookings = [...Bookings].sort((a, b) => { |
There was a problem hiding this comment.
You should be able to do Bookings.sort here. Any particular reason you're done it this way?
| // Convert string room IDs to numbers for proper sorting | ||
| aValue = parseInt(aValue); | ||
| bValue = parseInt(bValue); | ||
| } |
|
|
||
| const sortOrder = sortConfig.direction === 'ascending' ? 1 : -1; | ||
| return aValue - bValue * sortOrder; | ||
| }); |
There was a problem hiding this comment.
The code could use a comment here - not easy to tell what it does
| <th onClick={() => handleSort('roomId')}>Room ID</th> | ||
| <th onClick={() => handleSort('checkInDate')}>Check In Date</th> | ||
| <th onClick={() => handleSort('checkOutDate')}>Check Out Date</th> | ||
| </tr> |
There was a problem hiding this comment.
This works however and idea for next time: it's worth thinking about using .map() on an array for these sorts of things - can make it tider thouht this is up to your prefrence
| @@ -22,5 +22,5 @@ th { | |||
| cursor: pointer; | |||
| } | |||
| .selected { | |||
| background-color: skyblue; | |||
| background-color: rgb(241, 176, 249); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.