-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Borderless Mode (Windows) #1394
base: master
Are you sure you want to change the base?
Conversation
Borderless Mode (for Windows)
Opps, Missings from local other Ares Source added
Most comments should be removed as an accepted PR will credit the written code to the appropriate author. |
Hello, Ah OK, the comments are gone. They only serve as "bookmarks" so that you know where something has been changed. Thanks and greetings. :) |
You can probably also remove the "Marty2Life Borderless BEG" and "Randloses Fenster Commandline --------- BEGIN" comments since those are not necessary. Also are you going to update the hardcoded value with something else, or is that hardcoded permanent for the foreseeable future? |
No, the value is "Temporary Hard" and needs to be refined by a dynamic height calculation through the API in future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some questions and feedback.
I know we don't have a formal document that specifies coding style, but please try to match the style of surrounding code.
I stopped pointing out tab/spacing issues after a while, but inconsistent tab-width seems to be a common thread here.
I hope the space and tab are correct. I use Notepad++, changed tab to 2 spaces . greetings :) |
Hello, i have added a Borderless mode for the Windows version.
I only use Ares in window desktop mode with shaders and bezels but the frame around the window was bothering me and I still use Windows 7.
Can be activated via the command line (--noBorderless/ --Borderless) or via the menu. or via Hotkey.
Might be useful for some users. :)
I have no technical knowledge of Linux or Mac APIs.
greetings
Edit: I use Msys2
g++.exe (Rev1, Built by MSYS2 project) 11.3.0 under Windows 7