Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove red box around links and move appendix after references #4

Merged
merged 2 commits into from
Nov 1, 2024

Conversation

nsryan2
Copy link
Member

@nsryan2 nsryan2 commented Nov 1, 2024

Summary of changes

This PR addresses comment @munkm made to me about removing the red boxes around hyper-linked elements. As you can see from the changes, I've added the line:
\hypersetup{hidelinks}
which does just that.

I also noticed that @samgdotson had an old issue about the order of sections in the template. So I moved the appendix below the references in main.tex. As such, this PR closes #3.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Associated Issues and PRs

Checklist for Reviewers

Reviewers should use this link to get to the
Review Checklist before they begin their review.

Copy link
Contributor

@ZoeRichter ZoeRichter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link

@yardasol yardasol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job nathan!

Comment on lines +137 to +142
\newcommand\mainmatterWithoutReset
{\edef\temppagenumber{\arabic{page}}%
\mainmatter
\setcounter{page}{\temppagenumber}%
}
\mainmatterWithoutReset
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice!

Copy link
Contributor

@ZoeRichter ZoeRichter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (again)!

@ZoeRichter ZoeRichter merged commit 7c65cf8 into arfc:master Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: completed
Development

Successfully merging this pull request may close these issues.

Appendix and References order
3 participants