Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected AzureOpenAILLM path to mock the internal class #1115

Merged
merged 2 commits into from
Feb 18, 2025

Conversation

dameikle
Copy link
Contributor

Updated the internal path for mocking the _prepare_structured_output call in the load method

Copy link
Member

@davidberenstein1957 davidberenstein1957 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dameikle. thanks for this PR.

Copy link

codspeed-hq bot commented Feb 4, 2025

CodSpeed Performance Report

Merging #1115 will improve performances by ×4.1

Comparing dameikle:fix_azure (f671940) with develop (f5ddbc6)

Summary

⚡ 1 improvements

Benchmarks breakdown

Benchmark BASE HEAD Change
test_cache_time 2,171.1 ms 523.5 ms ×4.1

Copy link

@kipkoei kipkoei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Encountered the same issue, this solves it.

@davidberenstein1957 davidberenstein1957 merged commit 2d4ec9a into argilla-io:develop Feb 18, 2025
5 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants