Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): add extension the top-bar action menu #19620

Merged
merged 1 commit into from
Aug 29, 2024
Merged

feat(ui): add extension the top-bar action menu #19620

merged 1 commit into from
Aug 29, 2024

Conversation

ashutosh16
Copy link
Contributor

@ashutosh16 ashutosh16 commented Aug 21, 2024 •
edited
Loading

Screen.Recording.2024-08-21.at.17.13.05.mov
  • Add topbar actionMenuExt. add custom widgets to perform a specific action

To test

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Aug 21, 2024 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Aug 21, 2024 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@ashutosh16 ashutosh16 changed the title feat(ui): add toolbar ext on the action menu feat(ui): add extension the top-bar action menu Aug 21, 2024
@ashutosh16 ashutosh16 requested a review from agilgur5 August 22, 2024 16:37
@ashutosh16 ashutosh16 force-pushed the action-button-ext branch 6 times, most recently from 0f111a1 to 7350562 Compare August 23, 2024 04:42
@ashutosh16 ashutosh16 marked this pull request as ready for review August 23, 2024 05:12
@ashutosh16 ashutosh16 requested review from a team as code owners August 23, 2024 05:12
agilgur5
agilgur5 approved these changes Aug 25, 2024
View reviewed changes
Copy link

@agilgur5 agilgur5 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me 👍

Just left stylistic comments below.
CD folks should double-check the behavior and docs since I'm not a regular contributor here

docs/developer-guide/extensions/ui-extensions.md Outdated Show resolved Hide resolved
docs/developer-guide/extensions/ui-extensions.md Outdated Show resolved Hide resolved
ui/src/app/applications/components/application-details/application-details.tsx Outdated Show resolved Hide resolved
ui/src/app/applications/components/application-details/application-details.tsx Outdated Show resolved Hide resolved
ui/src/app/applications/components/application-details/application-details.tsx Outdated Show resolved Hide resolved
docs/developer-guide/extensions/ui-extensions.md Outdated Show resolved Hide resolved
agilgur5
agilgur5 approved these changes Aug 26, 2024
View reviewed changes
Copy link

@agilgur5 agilgur5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-approved with no further stylistic comments. (there is a lint error to fix though)

@ashutosh16 ashutosh16 enabled auto-merge (squash) August 26, 2024 16:57
@ashutosh16 ashutosh16 requested a review from keithchong August 28, 2024 21:12
agilgur5
agilgur5 reviewed Aug 28, 2024
View reviewed changes
Copy link

@agilgur5 agilgur5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep the formatting and indentation consistent throughout, that makes it easier to read and interpret

docs/developer-guide/extensions/ui-extensions.md Outdated Show resolved Hide resolved
docs/developer-guide/extensions/ui-extensions.md Show resolved Hide resolved
docs/developer-guide/extensions/ui-extensions.md Show resolved Hide resolved
docs/developer-guide/extensions/ui-extensions.md Outdated Show resolved Hide resolved
docs/developer-guide/extensions/ui-extensions.md Outdated Show resolved Hide resolved
add button ext in toolbar
c293a30 
Signed-off-by: ashutosh16 <[email protected]>
@ashutosh16 ashutosh16 merged commit 00466c3 into master Aug 29, 2024
25 of 26 checks passed
@ashutosh16 ashutosh16 deleted the action-button-ext branch August 29, 2024 12:48
agilgur5
agilgur5 reviewed Aug 31, 2024
View reviewed changes
Copy link

@agilgur5 agilgur5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a bunch of unnecessary indentation issues, some of which I previously corrected for you and were undone.

Please ensure to double-check the diff yourself at least once prior to asking for code review; these issues are fairly easy to spot in the diff and GH points some of them out too. Reviewing your own code is also a best practice.

docs/developer-guide/extensions/ui-extensions.md Show resolved Hide resolved
docs/developer-guide/extensions/ui-extensions.md Show resolved Hide resolved
docs/developer-guide/extensions/ui-extensions.md
Comment on lines +149 to +151
"div",
{ style: { padding: "10px" } },
"This is a flyout"
Copy link

@agilgur5 agilgur5 Aug 31, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

docs/developer-guide/extensions/ui-extensions.md Show resolved Hide resolved
docs/developer-guide/extensions/ui-extensions.md
Comment on lines +214 to +220
component,
"Toolbar Extension Test",
"Toolbar_Extension_Test",
flyout,
shouldDisplay,
'',
true
Copy link

@agilgur5 agilgur5 Aug 31, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above. this also undoes a previous suggestion I made that you had accepted...

docs/developer-guide/extensions/ui-extensions.md Show resolved Hide resolved
docs/developer-guide/extensions/ui-extensions.md Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agilgur5 agilgur5 agilgur5 approved these changes

@keithchong keithchong keithchong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ashutosh16 @agilgur5 @keithchong