fix(argo-workflows): Add unhealthyPodEvictionPolicy to workflow controller PDB #3012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fleuryc-owkin
requested review from
vladlosev,
jmeridth,
yu-croco and
tico24
as code owners
fleuryc-owkin
force-pushed
the
fix/wf-controller-pdb-unhealthyPodEvictionPolicy
branch
from
35975a4
to
11ebb3d
Compare
tico24
requested changes
Nov 7, 2024
| @@ -14,6 +14,7 @@ spec: | |||
| {{- else }} | |||
| minAvailable: 0 | |||
| {{- end }} | |||
| unhealthyPodEvictionPolicy: IfHealthyBudget | |||
There was a problem hiding this comment.
Feels like this should be user-configurable as some users may well prefer AlwaysAllow
There was a problem hiding this comment.
Done ✅
I ran ./scripts/helm-docs.sh but the attribute doesn't show up in the doc. What did I do wrong ?
|
Also this only went stable fairly recently didn't it (maybe 1.31 from memory)? How will this work for older k8s clusters? |
fleuryc-owkin
force-pushed
the
fix/wf-controller-pdb-unhealthyPodEvictionPolicy
branch
from
11ebb3d
to
75a88df
Compare
I added a comment and made the parameter optional. |
tico24
reviewed
Nov 7, 2024
charts/argo-workflows/values.yaml
Outdated
| @@ -344,6 +344,9 @@ controller: | |||
| enabled: false | |||
| # minAvailable: 1 | |||
| # maxUnavailable: 1 | |||
|
|
|||
| # -- [unhealthyPodEvictionPolicy] is only valid for v1.31+ | |||
There was a problem hiding this comment.
v1.31 of what?
It's valid for earlier versions but it's behind a gate.
…oller PDB Signed-off-by: Clément FLEURY <[email protected]>
fleuryc-owkin
force-pushed
the
fix/wf-controller-pdb-unhealthyPodEvictionPolicy
branch
from
75a88df
to
cd21b38
Compare
yu-croco
reviewed
Nov 10, 2024
Comment on lines
19
to
20
| - kind: added | ||
| description: Support lifecycle and terminationGracePeriodSeconds for server |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3011
Checklist: