-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(notification): fit long words #546
fix(notification): fit long words #546
Conversation
1363065
to
5fd8cb7
Compare
@crenshaw-dev Kindly help to review this PR |
Hi @crenshaw-dev @jmeridth @terrytangyuan @rbreeze |
Hi @agilgur5 |
Yes, I had been planning to; I'm not sure why you asked several other uninvolved people for review a day after you made changes, which was a full 2 weeks after changes were requested. Please be patient, especially if you yourself do not respond immediately -- it would not be surprising if a maintainer took as long as you did to respond if not longer -- I don't think it's reasonable to expect maintainers to be faster than you yourself. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are simpler ways of achieving this without overriding the component's styles, which can cause more problems and is not very reliable
168de7e
to
ec16186
Compare
Signed-off-by: Jessie <[email protected]>
Signed-off-by: Jessie <[email protected]>
Signed-off-by: Jessie <[email protected]>
Signed-off-by: Jessie <[email protected]>
Signed-off-by: Jessie Teng <[email protected]>
913862f
to
b6ef8b6
Compare
Hi @agilgur5 |
Signed-off-by: Jessie Teng <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for noting and fixing this issue
Did this change add the following CSS? .Toastify__toast-body > div:last-child {
word-break: break-word;
...
} If so, it is not working as expected as it is breaking short words too. Did you mean to use this instead? overflow-wrap: break-word;
|
Fixes #512
It is a layout issue when there is a long word in the error message toast popup, so added a style in that component to fix the issue.
Screenshots:
before fix:
after fix: