fix: switch to wf.Status.Phase.Completed()

Signed-off-by: Ilia Medvedev <[email protected]>
argoproj · Sep 4, 2024 · 4db8ec8 · 4db8ec8
1 parent 35724ad
commit 4db8ec8
Showing 1 changed file with 1 addition and 9 deletions.
diff --git a/cmd/argo/commands/common/wait.go b/cmd/argo/commands/common/wait.go
@@ -70,15 +70,7 @@ func waitOnOne(serviceClient workflowpkg.WorkflowServiceClient, ctx context.Cont
 		}
 		wf := event.Object
 
-		isWorkflowInTerminalState := func(wf *wfv1.Workflow) bool {
-			if !wf.Status.FinishedAt.IsZero() {
-				return true
-			} else {
-				return wf.Status.Phase == wfv1.WorkflowFailed || wf.Status.Phase == wfv1.WorkflowError || wf.Status.Phase == wfv1.WorkflowSucceeded
-			}
-		}
-
-		if wf != nil && isWorkflowInTerminalState(wf) {
+		if wf != nil && wf.Status.Phase.Completed() {
 			if !quiet {
 				fmt.Printf("%s %s at %v\n", wfName, wf.Status.Phase, wf.Status.FinishedAt)
 			}