Skip to content

Commit

Permalink
fix delete gc-artifact workflow stuck due to finalizers can not be …
Browse files Browse the repository at this point in the history
…removed

Signed-off-by: joey <[email protected]>
  • Loading branch information
chengjoey committed Aug 24, 2024
1 parent ddbb3c7 commit 5119e99
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion workflow/controller/artifact_gc.go
Original file line number Diff line number Diff line change
Expand Up @@ -508,7 +508,7 @@ func (woc *wfOperationCtx) processArtifactGCCompletion(ctx context.Context) erro
return fmt.Errorf("failed to get pods from informer: %w", err)
}

anyPodSuccess := false
anyPodSuccess := len(pods) == 0
for _, obj := range pods {
pod := obj.(*corev1.Pod)
if pod.Labels[common.LabelKeyComponent] != artifactGCComponent { // make sure it's an Artifact GC Pod
Expand Down

0 comments on commit 5119e99

Please sign in to comment.