fix: Correct limit in controller List API calls. Fixes #11134 (#11343)

Signed-off-by: Yuan Tang <[email protected]>

workflow/controller/controller.go

@@ -808,6 +808,9 @@ func (wfc *WorkflowController) tweakListOptions(options *metav1.ListOptions) {
 	labelSelector := labels.NewSelector().
 		Add(util.InstanceIDRequirement(wfc.Config.InstanceID))
 	options.LabelSelector = labelSelector.String()
+	// `ResourceVersion=0` does not honor the `limit` in API calls, which results in making significant List calls
+	// without `limit`. For details, see https://github.com/argoproj/argo-workflows/pull/11343
+	options.ResourceVersion = ""
 }
 
 func getWfPriority(obj interface{}) (int32, time.Time) {

workflow/controller/informer/tolerant_cluster_workflow_template_informer.go

@@ -21,8 +21,11 @@ type tolerantClusterWorkflowTemplateInformer struct {
 
 // a drop-in replacement for `extwfv1.ClusterWorkflowTemplateInformer` that ignores malformed resources
 func NewTolerantClusterWorkflowTemplateInformer(dynamicInterface dynamic.Interface, defaultResync time.Duration) extwfv1.ClusterWorkflowTemplateInformer {
-	return &tolerantClusterWorkflowTemplateInformer{delegate: dynamicinformer.NewFilteredDynamicSharedInformerFactory(dynamicInterface, defaultResync, "", func(options *metav1.ListOptions) {}).
-		ForResource(schema.GroupVersionResource{Group: workflow.Group, Version: workflow.Version, Resource: workflow.ClusterWorkflowTemplatePlural})}
+	return &tolerantClusterWorkflowTemplateInformer{delegate: dynamicinformer.NewFilteredDynamicSharedInformerFactory(dynamicInterface, defaultResync, "", func(options *metav1.ListOptions) {
+		// `ResourceVersion=0` does not honor the `limit` in API calls, which results in making significant List calls
+		// without `limit`. For details, see https://github.com/argoproj/argo-workflows/pull/11343
+		options.ResourceVersion = ""
+	}).ForResource(schema.GroupVersionResource{Group: workflow.Group, Version: workflow.Version, Resource: workflow.ClusterWorkflowTemplatePlural})}
 }
 
 func (t *tolerantClusterWorkflowTemplateInformer) Informer() cache.SharedIndexInformer {

workflow/controller/informer/tolerant_workflow_template_informer.go

@@ -21,8 +21,11 @@ type tolerantWorkflowTemplateInformer struct {
 
 // a drop-in replacement for `extwfv1.WorkflowTemplateInformer` that ignores malformed resources
 func NewTolerantWorkflowTemplateInformer(dynamicInterface dynamic.Interface, defaultResync time.Duration, namespace string) extwfv1.WorkflowTemplateInformer {
-	return &tolerantWorkflowTemplateInformer{delegate: dynamicinformer.NewFilteredDynamicSharedInformerFactory(dynamicInterface, defaultResync, namespace, func(options *metav1.ListOptions) {}).
-		ForResource(schema.GroupVersionResource{Group: workflow.Group, Version: workflow.Version, Resource: workflow.WorkflowTemplatePlural})}
+	return &tolerantWorkflowTemplateInformer{delegate: dynamicinformer.NewFilteredDynamicSharedInformerFactory(dynamicInterface, defaultResync, namespace, func(options *metav1.ListOptions) {
+		// `ResourceVersion=0` does not honor the `limit` in API calls, which results in making significant List calls
+		// without `limit`. For details, see https://github.com/argoproj/argo-workflows/pull/11343
+		options.ResourceVersion = ""
+	}).ForResource(schema.GroupVersionResource{Group: workflow.Group, Version: workflow.Version, Resource: workflow.WorkflowTemplatePlural})}
 }
 
 func (t *tolerantWorkflowTemplateInformer) Informer() cache.SharedIndexInformer {