test: Fix flaky test TestWorkflowLevelHooksWaitForTriggeredHook #11346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuan Tang <[email protected]>
terrytangyuan
commented
Jul 12, 2023
Comment on lines
+371
to
+372
| // TODO: This is sometimes "1/1" which might be a bug we need to investigate later. | ||
| //assert.Equal(t, status.Progress, v1alpha1.Progress("2/2")) |
There was a problem hiding this comment.
cc @GeunSam2 might be interested in taking a look
juliev0
approved these changes
Jul 12, 2023
tico24
pushed a commit
to tico24/argo-workflows
that referenced
this pull request
Jul 13, 2023
…proj#11346) Signed-off-by: Yuan Tang <[email protected]> Signed-off-by: Tim Collins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes one of the flaky tests #10807 (comment). I've seen this multiple times this week.