fix: replace deprecated bouk/staticfiles with native Go embed. fixes #11654

[sonbui00]

Fixes #11654

Motivation

• bouk/staticfiles is deprecated
• Sometime server/static/files.go is added to git commit unexpectedly

Modifications

• remove bouk/staticfiles, use standard lib

Verification

• make test
• manual check

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[sonbui00]

@agilgur5 Should I do anything to go forward for this?

[agilgur5]

Usually the process is that someone does initial reviews and if it's not an approver, we wait for an approver to then approve and merge.

Workflows doesn't have many active approvers so there's occasionally a backlog as there is now. I also have some PRs that have been open for 3+ weeks 😕 That is probably the longest wait I've seen in the past few months though, fwiw (I've only been actively contributing the past few, so can't say beyond that).

I had initially deferred review to someone who may know embed etc better (I have used it exactly once as part of a CLI, not a server), but Workflows might not actually have any contributors familiar with it, so maybe I should do first review.

[agilgur5]

For context, I am currently a Member (though may become a Reviewer at the next membership meeting). Lead > Approver > Reviewer > Member. You can see the Argo governance docs here.
You are also welcome to request Membership if you're interested 😉 (we can probably find a sponsor as well; sponsors must be approvers+, though support from others in the community like me helps!)

[isubasinghe]

I am happy with this, looks sensible, the one suggestion I would like to state is that perhaps some generation of the strings used for ByteReedSeeker could be done? Currently only a single "hello world" string is used in all the test cases.

[juliev0]

@sonbui00 sorry this ended up being delayed. I see @isubasinghe approved this awhile back. @isubasinghe is now an Approver and can merge. Do you want to fix the merge conflicts and get this merged still?

[sonbui00]

@juliev0 I'll check it

[juliev0]

let me know when you've fixed the codegen and lint issues and we can merge this

[sonbui00]

@juliev0 codegen and lint issues have been fixed. help me review

[juliev0]

Sorry @isubasinghe - it looks like your original review has been removed with the fixes @sonbui00 made . Can you re-review/merge when you have time?

[isubasinghe]

@sonbui00 Could you please fix the merge conflicts? I will merge this in ASAP, sorry about forgetting to re-review this, just have a million things to do atm.

[Joibel]

Thanks so much for all your diligence on working through this one.