feat: added multi-select for input parameters. Fixes #12017

[ahrakos]

Fixes #12017

Motivation

I made my changes, because in Argo Workflows UI we weren't able to use a dropdown as a multi-select, and instantiate the default value to something that is accepted by a multi-select component.

Modifications

• I changed the definition of Parameter type, to include another field named multi which is of type boolean. Only when we use the multi-select, we should make sure that the multi value is being set to true, so the UI will treat the select box as a multi-select one, or either a single-select in case of a falsy-value.
• I changed the UI to consider the multi value, and to plant the relevant callbacks to support the multi-select behavior, as I've seen that the UI library that argo uses already supports multi-select, it's just that no one used it.

On Smaller Screen:

Verification

I saw that the UI doesn't have any kind of tests, so I manually checked that the functionality works in different screens that are using the parameters of type multi-select and single-select.

[terrytangyuan]

Could you test the responsiveness of the multi-selection dropdown?

[agilgur5]

I only took a quick look so far, but there is at least one problem that affects all of the codegen.

[ahrakos]

Could you test the responsiveness of the multi-selection dropdown?

Yes, it seems there is no infrastructure for ui tests, is there a preferred way/tools to do that in this project?

[agilgur5]

Yes, it seems there is no infrastructure for ui tests, is there a preferred way/tools to do that in this project?

There's some unit tests, but no component, functional, or E2E tests for the UI. Although responsiveness is usually tested with visual tests, which are rarer these days too.

Right now, we do a lot of manual testing for visual things, so a screenshot with your browser devtools set to a smaller screen would suffice for this.

I saw that the UI doesn't have any kind of tests, so I manually checked that the functionality works in different screens that are using the parameters of type multi-select and single-select.

i.e. this and attaching screenshots matches our current standards 👍
can do the same thing for responsiveness -- although I'm pretty sure the multi-select has no impact on responsiveness since it's the same size (or about?) as the singular select (and is a dep) 🤷

[ahrakos]

Added two more screenshots of 1024x768 screen size

[ahrakos]

@agilgur5 it seems that tests are a bit flaky, as at first all of them passed, but now each time I run, a different suite is failing. Can we rerun only the failing suites somehow?

[ahrakos]

@agilgur5
@terrytangyuan

Bumping as no response for more than a week

[agilgur5]

@agilgur5 it seems that tests are a bit flaky, as at first all of them passed, but now each time I run, a different suite is failing. Can we rerun only the failing suites somehow?

There was a recent flake that was fixed in #12596. It was hit very frequently, so a retry is not necessarily enough for that one. If you rebase, it should be fixed.

I haven't had a chance to review several PRs in-depth yet due to my status, hopefully will get to the simpler ones soon as I recover

[ahrakos]

@agilgur5 it seems that tests are a bit flaky, as at first all of them passed, but now each time I run, a different suite is failing. Can we rerun only the failing suites somehow?

There was a recent flake that was fixed in #12596. It was hit very frequently, so a retry is not necessarily enough for that one. If you rebase, it should be fixed.

I haven't had a chance to review several PRs in-depth yet due to my status, hopefully will get to the simpler ones soon as I recover

Be safe, I had the same issue as well, hope you'll feel better soon.
I rebased and it indeed helped, I'll keep an eye on the PR and wait for you to review :)

[ahrakos]

@agilgur5

Hey again, I hope you are feeling better!
Do you mind taking a look again at the PR?
It's been a while and I think this feature is really important with really small effort :)

I assume @sarabala1979 should look at it as well, so bumping just for a reminder!

[ahrakos]

@agilgur5 Any news with that?