-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: support local arm64 and amd64 image #12754
Conversation
I'd like by default not to build both images. In #12750 I asked for:
|
I would also like there to be a line in the documentation about this feature, documenting both single and multiple platform builds. |
Signed-off-by: heidongxianhua <[email protected]>
Signed-off-by: heidongxianhua <[email protected]>
Signed-off-by: heidongxianhua <[email protected]>
Signed-off-by: heidongxianhua <[email protected]>
Signed-off-by: heidongxianhua <[email protected]>
f084767
to
8307cf4
Compare
Signed-off-by: heidongxianhua <[email protected]>
Signed-off-by: heidongxianhua <[email protected]>
Signed-off-by: heidongxianhua <[email protected]>
sorry to delay, and now I have fixed it and give a case in docs to introduce how to use it. @Joibel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
I'd prefer an approach that didn't assume amd64 in non arm cases, but this is good enough for now and can iterate later.
@agilgur5, could you take another look please. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small adjustments in-line below
I'd prefer an approach that didn't assume amd64 in non arm cases, but this is good enough for now and can iterate later.
Agreed
Signed-off-by: heidongxianhua <[email protected]>
Signed-off-by: heidongxianhua <[email protected]>
Signed-off-by: heidongxianhua <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #12750
Motivation
Modifications
Verification