Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: support local arm64 and amd64 image #12754

Merged
merged 12 commits into from
Apr 7, 2024

Conversation

heidongxianhua
Copy link
Contributor

Fixes #12750

Motivation

Modifications

Verification

@Joibel Joibel self-assigned this Mar 7, 2024
@Joibel Joibel added the area/build Build or GithubAction/CI issues label Mar 7, 2024
@Joibel
Copy link
Member

Joibel commented Mar 7, 2024

I'd like by default not to build both images. In #12750 I asked for:

We'd accept a PR for formalizing this if you want to do it, so long as it only built for the "same as your machine" in the default case. You could set an environment variable to override this behavior.

@agilgur5 agilgur5 changed the title fix: support build arm64 and amd64 image local build: support local arm64 and amd64 image Mar 7, 2024
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@Joibel
Copy link
Member

Joibel commented Mar 8, 2024

I would also like there to be a line in the documentation about this feature, documenting both single and multiple platform builds.

@agilgur5 agilgur5 added the problem/more information needed Not enough information has been provide to diagnose this issue. label Mar 24, 2024
Signed-off-by: heidongxianhua <[email protected]>
Signed-off-by: heidongxianhua <[email protected]>
Signed-off-by: heidongxianhua <[email protected]>
Signed-off-by: heidongxianhua <[email protected]>
Signed-off-by: heidongxianhua <[email protected]>
@heidongxianhua
Copy link
Contributor Author

sorry to delay, and now I have fixed it and give a case in docs to introduce how to use it. @Joibel

Copy link
Member

@Joibel Joibel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

I'd prefer an approach that didn't assume amd64 in non arm cases, but this is good enough for now and can iterate later.

@Joibel
Copy link
Member

Joibel commented Apr 5, 2024

@agilgur5, could you take another look please.

Copy link

@agilgur5 agilgur5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small adjustments in-line below

I'd prefer an approach that didn't assume amd64 in non arm cases, but this is good enough for now and can iterate later.

Agreed

Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
docs/running-locally.md Outdated Show resolved Hide resolved
docs/running-locally.md Outdated Show resolved Hide resolved
Signed-off-by: heidongxianhua <[email protected]>
Signed-off-by: heidongxianhua <[email protected]>
Signed-off-by: heidongxianhua <[email protected]>
Copy link

@agilgur5 agilgur5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agilgur5 agilgur5 merged commit 3496712 into argoproj:main Apr 7, 2024
27 checks passed
@agilgur5 agilgur5 added area/contributing Contributing docs, ownership, etc. Also devtools like devcontainer and Nix and removed problem/more information needed Not enough information has been provide to diagnose this issue. labels Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build Build or GithubAction/CI issues area/contributing Contributing docs, ownership, etc. Also devtools like devcontainer and Nix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

local image build: support arm and amd64
3 participants