Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix some docs and comment typos #12841

Merged
merged 2 commits into from
Mar 26, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/retries.md
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ flowchart LR
onfailureNoExpr[OnFailure]
onfailure[OnFailure AND Expression]
version(Workflows version)
version-->|3.4 or ealier|onfailure
version-->|3.4 or earlier|onfailure
always[Only Expression matters]
version-->|3.5 or later|always
```
Expand Down
2 changes: 1 addition & 1 deletion examples/workflow-count-resourcequota.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ metadata:
<= v3.1 you can configure a global limit to the total number of running workflows in the cluster. This is suitable
for single-tenancy set-up.

For multi-tenancy set-up, where each tenant own a single namespace, then in >= v3.1 you can globaly configure a
For multi-tenancy set-up, where each tenant own a single namespace, then in >= v3.1 you can globally configure a
terrytangyuan marked this conversation as resolved.
Show resolved Hide resolved
limit for the total number of running workflows within each namespace.
spec:
hard:
Expand Down
2 changes: 1 addition & 1 deletion manifests/quick-start-minimal.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion manifests/quick-start-mysql.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion manifests/quick-start-postgres.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ metadata:
workflows.argoproj.io/description: |
Recommended minimum permissions for the `docker` executor.

This executor is superseded by the `emmisary` executor, so we do not recommend you use it anymore.
This executor is superseded by the `emissary` executor, so we do not recommend you use it anymore.
workflows.argoproj.io/version: "< 3.4.0"
rules:
- apiGroups:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ metadata:
name: executor
annotations:
workflows.argoproj.io/description: |
Recomended minimum permissions for the `emissary` executor.
Recommended minimum permissions for the `emissary` executor.
rules:
- apiGroups:
- argoproj.io
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ metadata:
workflows.argoproj.io/description: |
Recommended minimum permissions for `k8siapi` executor.

This executor is superseded by the `emmisary` executor, so we do not recommend you use it anymore.
This executor is superseded by the `emissary` executor, so we do not recommend you use it anymore.
workflows.argoproj.io/version: "< 3.4.0"
rules:
- apiGroups:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ metadata:
workflows.argoproj.io/description: |
Recommended minimum permissions for `kubelet` executor.

This executor is superseded by the `emmisary` executor, so we do not recommend you use it anymore.
This executor is superseded by the `emissary` executor, so we do not recommend you use it anymore.
workflows.argoproj.io/version: "< 3.4.0"
rules:
- apiGroups:
Expand Down
2 changes: 1 addition & 1 deletion manifests/quick-start/base/executor/pns/executor-role.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ metadata:
name: executor
annotations:
workflows.argoproj.io/description: |
Recomended minimum permissions for `pns` executor.
Recommended minimum permissions for `pns` executor.
workflows.argoproj.io/version: "< 3.4.0"
rules:
- apiGroups:
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/functional/retry-with-artifacts.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Verifies that retries with artifacts will propogate artifacts
# Verifies that retries with artifacts will propagate artifacts
apiVersion: argoproj.io/v1alpha1
kind: Workflow
metadata:
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/smoke/runasnonroot-output-params-pipeline.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ spec:
- test test
- /tmp/output-param.txt
# Accessing output parameters requires special permissions for the
# executor. Presense of an output parameter here will test that these
# executor. Presence of an output parameter here will test that these
# permissions are granted.
outputs:
parameters:
Expand Down
Loading