Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(sso): clarify Dex staticClients ID #12843

Merged
merged 2 commits into from
Mar 26, 2024
Merged

Conversation

DavidGamba
Copy link
Contributor

@DavidGamba DavidGamba commented Mar 25, 2024

Clarify that staticClients id is the OIDC client ID, not the secret name.

Fixes #TODO

Motivation

Modifications

Verification

Clarify that staticCLients id is the OIDC client ID, not the secret name.

Signed-off-by: David Gamba <davidgamba@gmail.com>
@DavidGamba DavidGamba changed the title Update argo-server-sso-argocd.md docs: update argo-server-sso-argocd.md Mar 25, 2024
@agilgur5 agilgur5 changed the title docs: update argo-server-sso-argocd.md docs(sso): clarify Dex staticClients ID Mar 25, 2024
@agilgur5 agilgur5 self-assigned this Mar 25, 2024
@agilgur5 agilgur5 added the area/docs Incorrect, missing, or mistakes in docs label Mar 25, 2024
Co-authored-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com>
Signed-off-by: David Gamba <davidgamba@gmail.com>
Copy link

@agilgur5 agilgur5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification!

@agilgur5 agilgur5 merged commit 24f791b into argoproj:main Mar 26, 2024
15 checks passed
@DavidGamba DavidGamba deleted the patch-1 branch March 26, 2024 13:22
agilgur5 pushed a commit that referenced this pull request May 4, 2024
Signed-off-by: David Gamba <davidgamba@gmail.com>
Co-authored-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com>
(cherry picked from commit 24f791b)
@agilgur5 agilgur5 added this to the v3.5.x patches milestone Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Incorrect, missing, or mistakes in docs area/sso-rbac
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants