feat: allow custom http client and use ctx for http1 apiclient. Fixes #12827 #12867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…client. Fixes argoproj#12827 the current implementation does not suite our usecase because the http Fascade interface does not take proxy url we have to use proxy for cross network calls for argo server so we might as well just allow a fully configured http client to be passed in - this allows more flexible configurations of the HTTP1 client via custom roundtripper Signed-off-by: williamburgson <[email protected]>
Joibel
approved these changes
Apr 9, 2024
This was referenced Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the current implementation does not suite our usecase because the http Fascade interface does not take proxy url we have to use proxy for cross network calls for argo server
so we might as well just allow a fully configured http client to be passed in - this allows more flexible configurations of the HTTP1 client via custom roundtripper
Fixes #12827
Motivation
Modifications
HTTP1ClientFacadeuse the custom http client if providedNewRequestWithContextto include context from callerdoto accept context from caller_ context.Context->ctx context.Context, and pass that doFacadeVerification