feat(ui): display line numbers in object-editor. Fixes #12807. #12873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agilgur5
changed the title
agilgur5
changed the title
agilgur5
reviewed
Apr 3, 2024
Signed-off-by: alizademhdi <[email protected]>
alizmhdi
force-pushed
the
FEAT/line-number-in-editor
branch
from
a2397b9 to
c6a8d65
Compare
|
It looks good. I also wanted to display the line number on the left to help debug. |
agilgur5
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue:
Fixes #12807
Motivation
Adding support for displaying the line number would enhance the user experience, as it would aid in debugging
Modifications
Remove
lineNumberskey inobject-editor.tsx.Verification
after changes:
before changes:
