Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): bump github.com/Azure/azure-sdk-for-go/sdk/storage/azblob from 1.2.1 to 1.3.2 #12915

Conversation

roelarents
Copy link
Contributor

Bumps github.com/Azure/azure-sdk-for-go/sdk/storage/azblob from 1.2.1 to 1.3.2.

Fix for a data race issue in azure azblob sdk.
And for another

Replaces #12667

Motivation

Update azure-sdk-for-go/sdk/storage/azblob to the latest version.

Dependabot would normally do this, but it has been explicitly disabled once and cannot be enabled again.

Modifications

A version update in go.mod. Ran go mod tidy.

Verification

Tested by:

  • make test
  • patched 3.5.5 with this and running in production

@agilgur5 agilgur5 added type/dependencies PRs and issues specific to updating dependencies go Pull requests that update Go dependencies area/artifacts S3/GCP/OSS/Git/HDFS etc area/upstream This is an issue with an upstream dependency, not Argo itself labels Apr 9, 2024
Copy link

@agilgur5 agilgur5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for iterating and testing this!

@agilgur5 agilgur5 merged commit 6c2211e into argoproj:main Apr 9, 2024
27 checks passed
agilgur5 pushed a commit that referenced this pull request Apr 9, 2024
… 1.2.1 to 1.3.2 (#12915)

Signed-off-by: Roel Arents <[email protected]>
Co-authored-by: agilgur5 <[email protected]>
(cherry picked from commit 6c2211e)
@agilgur5
Copy link

agilgur5 commented Apr 9, 2024

Backported into release-3.5 as e4d3c0f

  • Fixed a merge conflict with some older deps in a few places and ran go mod tidy after. Also had to backport a few older Azure dep upgrades to fix a bunch of other merge conflicts

@agilgur5 agilgur5 added this to the v3.5.x patches milestone Apr 9, 2024
@agilgur5 agilgur5 changed the title chore: bump github.com/Azure/azure-sdk-for-go/sdk/storage/azblob from 1.2.1 to 1.3.2 fix(deps): bump github.com/Azure/azure-sdk-for-go/sdk/storage/azblob from 1.2.1 to 1.3.2 Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/artifacts S3/GCP/OSS/Git/HDFS etc area/upstream This is an issue with an upstream dependency, not Argo itself go Pull requests that update Go dependencies type/dependencies PRs and issues specific to updating dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants