fix: correct pod names for inline templates. Fixes #12895

[AlbeeSo]

Fixes #12895

Motivation

argo-workflows/workflow/util/pod_name.go

Line 60 in 87a2041

if !strings.Contains(nodeName, ".inline") {

inline-cant-show-errors-9ptb9--3016472844   0/2     Error       0               25h
inline-cant-show-errors-9ptb9--3942528235   0/2     Completed   0               25h

Incorrect pod names of inline templates will lead to empty UI logs problem.

Modifications

Verification

Test with the workflow mentioned in issue, got result like image post below:

[terrytangyuan]

Can you add a test?

[agilgur5]

I see the UI logic for pod names has diverged a bit -- #7605 added a templateName !== '' check to the UI but not the back-end (and the conditional was subtly changed in #11016 too). This looks vaguely correct based on that, but the UI seems to have no check for inline templates? Conversely, #10921 added the inline check to the back-end but not the UI?

This logic could perhaps be simplified to just templateName != "" and the inline check removed?

[agilgur5]

@shuangkun do you or @AlbeeSo plan to update this PR with the requested changes?
No changes have been made in 4 days since you re-opened the PR, so I'm not sure why it was re-opened

[agilgur5]

Superseded by #13261