feat: new pod phase counter metric #13272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joibel
force-pushed
the
opentelemetry-k8sduration
branch
from
6084e25 to
a5f5cb4
Compare
Joibel
force-pushed
the
opentelemetry-podphase
branch
from
6729538 to
432d8fc
Compare
agilgur5
changed the title
Joibel
force-pushed
the
opentelemetry-k8sduration
branch
2 times, most recently
from
49a3c4d to
8c74273
Compare
Joibel
force-pushed
the
opentelemetry-podphase
branch
from
432d8fc to
4096782
Compare
Joibel
force-pushed
the
opentelemetry-k8sduration
branch
from
8c74273 to
f8c31f7
Compare
Joibel
force-pushed
the
opentelemetry-podphase
branch
from
4096782 to
14a762e
Compare
Joibel
force-pushed
the
opentelemetry-k8sduration
branch
from
f8c31f7 to
fc9b88e
Compare
Joibel
force-pushed
the
opentelemetry-podphase
branch
from
14a762e to
9cf9291
Compare
Joibel
force-pushed
the
opentelemetry-k8sduration
branch
from
fc9b88e to
06a6583
Compare
Joibel
force-pushed
the
opentelemetry-podphase
branch
from
9cf9291 to
55742dd
Compare
Joibel
force-pushed
the
opentelemetry-k8sduration
branch
from
06a6583 to
457c8ec
Compare
Joibel
force-pushed
the
opentelemetry-podphase
branch
from
55742dd to
bbd57a4
Compare
Joibel
force-pushed
the
opentelemetry-k8sduration
branch
from
457c8ec to
705be42
Compare
Joibel
force-pushed
the
opentelemetry-podphase
branch
from
bbd57a4 to
62717f1
Compare
Joibel
force-pushed
the
opentelemetry-k8sduration
branch
from
705be42 to
dc3469a
Compare
Joibel
force-pushed
the
opentelemetry-podphase
branch
from
62717f1 to
914bffe
Compare
Joibel
force-pushed
the
opentelemetry-k8sduration
branch
from
dc3469a to
e825f72
Compare
Joibel
force-pushed
the
opentelemetry-podphase
branch
from
914bffe to
ed07b58
Compare
Joibel
force-pushed
the
opentelemetry-k8sduration
branch
from
e825f72 to
8f3216d
Compare
Joibel
force-pushed
the
opentelemetry-podphase
branch
from
ed07b58 to
b09c0d2
Compare
Joibel
force-pushed
the
opentelemetry-k8sduration
branch
from
8f3216d to
e18eac6
Compare
Joibel
force-pushed
the
opentelemetry-podphase
branch
2 times, most recently
from
4765408 to
e90ca47
Compare
Joibel
changed the title
From #12589 This is a new metric counting how many pods have gone into each pod phase as observed by the controller. This is like pods_gauge, but as a counter rather than a gauge. The gauge is useful at telling you what is happening right now in the cluster, but is not useful for long term statistics such as "How many pods has workflows run" because it may never report some pods at all. This counter can answer that question. Note to reviewers: this is part of a stack of reviews for metrics changes. Please don't merge until the rest of the stack is also ready. Signed-off-by: Alan Clucas <[email protected]>
Joibel
force-pushed
the
opentelemetry-podphase
branch
from
d379834 to
454b5a8
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #12589
This is a new metric counting how many pods have gone into each pod phase as observed by the controller.
This is like pods_gauge, but as a counter rather than a gauge.
The gauge is useful at telling you what is happening right now in the cluster, but is not useful for long term statistics such as "How many pods has workflows run" because it may never report some pods at all. This counter can answer that question.
Note to reviewers: this is now a standalone commit