feat: new pod pending counter metric #13273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joibel
force-pushed
the
opentelemetry-podphase
branch
from
6729538 to
432d8fc
Compare
Joibel
force-pushed
the
opentelemetry-podpending
branch
from
4daa3a0 to
fe4d153
Compare
agilgur5
changed the title
Joibel
force-pushed
the
opentelemetry-podphase
branch
from
432d8fc to
4096782
Compare
Joibel
force-pushed
the
opentelemetry-podpending
branch
from
fe4d153 to
0401646
Compare
Joibel
force-pushed
the
opentelemetry-podphase
branch
from
4096782 to
14a762e
Compare
Joibel
force-pushed
the
opentelemetry-podpending
branch
from
0401646 to
34739c8
Compare
Joibel
force-pushed
the
opentelemetry-podphase
branch
from
14a762e to
9cf9291
Compare
Joibel
force-pushed
the
opentelemetry-podpending
branch
from
34739c8 to
c2aa5eb
Compare
Joibel
force-pushed
the
opentelemetry-podphase
branch
from
9cf9291 to
55742dd
Compare
Joibel
force-pushed
the
opentelemetry-podpending
branch
from
c2aa5eb to
a269114
Compare
Joibel
force-pushed
the
opentelemetry-podphase
branch
from
55742dd to
bbd57a4
Compare
Joibel
force-pushed
the
opentelemetry-podpending
branch
from
a269114 to
7980eec
Compare
Joibel
force-pushed
the
opentelemetry-podphase
branch
from
bbd57a4 to
62717f1
Compare
Joibel
force-pushed
the
opentelemetry-podpending
branch
from
7980eec to
406bb3a
Compare
Joibel
force-pushed
the
opentelemetry-podphase
branch
from
62717f1 to
914bffe
Compare
Joibel
force-pushed
the
opentelemetry-podpending
branch
from
406bb3a to
214ee64
Compare
Joibel
force-pushed
the
opentelemetry-podphase
branch
from
914bffe to
ed07b58
Compare
Joibel
force-pushed
the
opentelemetry-podpending
branch
from
214ee64 to
e5ce65c
Compare
Joibel
force-pushed
the
opentelemetry-podphase
branch
from
ed07b58 to
b09c0d2
Compare
Joibel
force-pushed
the
opentelemetry-podpending
branch
from
e5ce65c to
69dfcca
Compare
Joibel
force-pushed
the
opentelemetry-podphase
branch
from
b09c0d2 to
4765408
Compare
Joibel
force-pushed
the
opentelemetry-podpending
branch
from
69dfcca to
d1a14c8
Compare
Joibel
force-pushed
the
opentelemetry-podphase
branch
from
4765408 to
e90ca47
Compare
Joibel
force-pushed
the
opentelemetry-podpending
branch
from
d1a14c8 to
f6fa6d5
Compare
Joibel
changed the title
Joibel
force-pushed
the
opentelemetry-podpending
branch
from
3bd0249 to
fe9fd68
Compare
The workflow controller is a kubernetes controller creating pods. Sometimes those pods do not start, and will remain in pending. This metric counts the number of pods that may have been observed as pending, by namespace and truncated reason. The reason is the first part of the kubernetes pod pending `Reason` up to the first `:` if present. It ignores all pods in the `PodInitializing` state as this I consider unremarkable and temporary. This is intended for users to create alerts on particular `reasons` or if this metric is climbing unusually rapidly. Note to reviewers: this is part of a stack of reviews for metrics changes. Please don't merge until the rest of the stack is also ready. Signed-off-by: Alan Clucas <[email protected]>
Joibel
force-pushed
the
opentelemetry-podpending
branch
from
fe9fd68 to
e44a2b9
Compare
IIRC there are some cases where users had Pods stuck in this state, so it might be useful for detecting those. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The workflow controller is a kubernetes controller creating pods. Sometimes those pods do not start, and will remain in pending.
This metric counts the number of pods that may have been observed as pending, by namespace and truncated reason. The reason is the first part of the kubernetes pod pending
Reasonup to the first:ifpresent.
It ignores all pods in the
PodInitializingstate as this I consider unremarkable and temporary.This is intended for users to create alerts on particular
reasonsor if this metric is climbing unusually rapidly.Note to reviewers: this is now a standalone commit