feat: new cron workflow trigger counter metric #13274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joibel
force-pushed
the
opentelemetry-podpending
branch
from
4daa3a0 to
fe4d153
Compare
Joibel
force-pushed
the
opentelemetry-crontrigger
branch
from
c5d2f77 to
dc7479a
Compare
agilgur5
changed the title
Joibel
force-pushed
the
opentelemetry-podpending
branch
from
fe4d153 to
0401646
Compare
Joibel
force-pushed
the
opentelemetry-crontrigger
branch
from
dc7479a to
38143f4
Compare
Joibel
force-pushed
the
opentelemetry-podpending
branch
from
0401646 to
34739c8
Compare
Joibel
force-pushed
the
opentelemetry-crontrigger
branch
from
38143f4 to
481c236
Compare
Joibel
force-pushed
the
opentelemetry-podpending
branch
from
34739c8 to
c2aa5eb
Compare
Joibel
force-pushed
the
opentelemetry-crontrigger
branch
from
481c236 to
18bb3a9
Compare
Joibel
force-pushed
the
opentelemetry-podpending
branch
from
c2aa5eb to
a269114
Compare
Joibel
force-pushed
the
opentelemetry-crontrigger
branch
from
18bb3a9 to
9def3b4
Compare
Joibel
force-pushed
the
opentelemetry-podpending
branch
from
a269114 to
7980eec
Compare
Joibel
force-pushed
the
opentelemetry-crontrigger
branch
from
9def3b4 to
aaf38bd
Compare
Joibel
force-pushed
the
opentelemetry-podpending
branch
from
7980eec to
406bb3a
Compare
Joibel
force-pushed
the
opentelemetry-crontrigger
branch
from
aaf38bd to
98775d8
Compare
Joibel
force-pushed
the
opentelemetry-podpending
branch
from
406bb3a to
214ee64
Compare
Joibel
force-pushed
the
opentelemetry-crontrigger
branch
from
98775d8 to
a43524a
Compare
Joibel
force-pushed
the
opentelemetry-podpending
branch
from
214ee64 to
e5ce65c
Compare
Joibel
force-pushed
the
opentelemetry-crontrigger
branch
from
a43524a to
45303a9
Compare
Joibel
force-pushed
the
opentelemetry-podpending
branch
from
e5ce65c to
69dfcca
Compare
Joibel
force-pushed
the
opentelemetry-crontrigger
branch
from
45303a9 to
e2eecd2
Compare
Joibel
force-pushed
the
opentelemetry-podpending
branch
from
69dfcca to
d1a14c8
Compare
Joibel
force-pushed
the
opentelemetry-crontrigger
branch
from
e2eecd2 to
8f68609
Compare
Joibel
force-pushed
the
opentelemetry-podpending
branch
from
d1a14c8 to
f6fa6d5
Compare
Joibel
changed the title
Joibel
force-pushed
the
opentelemetry-crontrigger
branch
from
8f68609 to
075816f
Compare
From #12589. A new metric which counts how many times each cron workflow has triggered. A simple enough counter which can be checked against expectations for the cron. Note to reviewers: this is part of a stack of reviews for metrics changes. Please don't merge until the rest of the stack is also ready. Signed-off-by: Alan Clucas <[email protected]>
Joibel
force-pushed
the
opentelemetry-crontrigger
branch
from
cf87ddc to
780f611
Compare
agilgur5
reviewed
Aug 19, 2024
| @@ -201,6 +201,15 @@ Metrics for the [Four Golden Signals](https://sre.google/sre-book/monitoring-dis | |||
| Some metric attributes may have high cardinality and are marked with ⚠️ to warn you. You may need to disable this metric or disable the attribute. | |||
| <!-- titles should be the exact metric name for deep-linking, alphabetical ordered --> | |||
| <!-- titles are without argo_workflows prefix --> | |||
| #### `cronworkflows_triggered_total` | |||
|
|
|||
There was a problem hiding this comment.
Suggested change
| > v3.6 and after |
Version reference
| @@ -201,6 +201,15 @@ Metrics for the [Four Golden Signals](https://sre.google/sre-book/monitoring-dis | |||
| Some metric attributes may have high cardinality and are marked with ⚠️ to warn you. You may need to disable this metric or disable the attribute. | |||
| <!-- titles should be the exact metric name for deep-linking, alphabetical ordered --> | |||
| <!-- titles are without argo_workflows prefix --> | |||
There was a problem hiding this comment.
I'd probably add a new line above and below this comment. A bit surprised markdownlint didn't require that
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #12589.
A new metric which counts how many times each cron workflow has triggered. A simple enough counter which can be checked against expectations for the cron.
Note to reviewers: this is now a standalone commit