-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new template counting and phase counting metrics #13275
Conversation
@Joibel since these ones aren't draft, does that mean they're ready to review but not ready to merge? What we can do to indicate that is to add a "[DO NOT MERGE] " prefix to the title of each of these -- since that will fail the PR title check, it won't be mergeable and is a pretty big indicator too. Or "[Please Review but DO NOT MERGE] " or something |
These are ready for review. Merging isn't a disaster, it just makes any merged into PRs slightly harder to review. I was hoping anyone reviewing would do enough reading not to merge with the existing words I've written. The whole thing is an experiment in highly stacked PRs from my point of view. |
c5d2f77
to
dc7479a
Compare
5fecb02
to
1d73fc2
Compare
Unfortunately, I'm not sure that's always the case 😕 But more importantly, there's also the muscle memory of the "Approve" -> "Merge" process that makes it more likely to happen unintentionally. As such, I'm gonna mark them as "[DNM]" and maybe put an emoji indicating reviewed or not for at a glance filtering. Also "[1/12]" would work too as a blocking prefix |
dc7479a
to
38143f4
Compare
1d73fc2
to
69d8583
Compare
38143f4
to
481c236
Compare
69d8583
to
ec5cc91
Compare
481c236
to
18bb3a9
Compare
ec5cc91
to
f24afc8
Compare
18bb3a9
to
9def3b4
Compare
f24afc8
to
b959898
Compare
9def3b4
to
aaf38bd
Compare
b959898
to
27b6d50
Compare
aaf38bd
to
98775d8
Compare
27b6d50
to
c7a6897
Compare
98775d8
to
a43524a
Compare
c7a6897
to
f351e1b
Compare
a43524a
to
45303a9
Compare
f351e1b
to
02f7860
Compare
45303a9
to
e2eecd2
Compare
58498ce
to
b10d732
Compare
8f68609
to
075816f
Compare
b10d732
to
e12e15c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small comment
4cca2a8
to
44cb0d6
Compare
From #12589. New metric `total_count` which is like the old `count` metric and the new `gauge` metric, but a counter, not a gauge. The gauge shows a snapshot of what is happening right now in the cluster, the counter can answer questions like how many `Failed` workflows have there been in the last 24 hours. Two further metrics for counting uses of WorkflowTemplates via workflowTemplateRef only. These store the name of the WorkflowTemplate or ClusterWorkflowTemplate if the `cluster_scope` label is true, and the namespace where it is used. `workflowtemplate_triggered_total` counts the number of uses. `workflowtemplate_runtime` records how long each phase the workflow running the template spent in seconds. Note to reviewers: this is part of a stack of reviews for metrics changes. Please don't merge until the rest of the stack is also ready. Signed-off-by: Alan Clucas <[email protected]>
44cb0d6
to
15fabdb
Compare
Signed-off-by: Alan Clucas <[email protected]>
15fabdb
to
5175e6d
Compare
From #12589.
New metric
total_count
which is like the oldcount
metric and the newgauge
metric, but a counter, not a gauge. The gauge shows a snapshot of what is happening right now in the cluster, the counter can answer questions like how manyFailed
workflows have there been in the last 24 hours.Two further metrics for counting uses of WorkflowTemplates via workflowTemplateRef only. These store the name of the WorkflowTemplate or ClusterWorkflowTemplate if the
cluster_scope
label is true, and the namespace where it is used.workflowtemplate_triggered_total
counts the number of uses.workflowtemplate_runtime
records how longeach phase the workflow running the template spent in seconds.
Note to reviewers: this is now a standlone commit