refactor(tests): testifylint automated fixes #13396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joibel
changed the title
This is part of a series of test tidies started by #13365. The aim is to enable the testifylint golangci-lint checker. This patch is just the automated fixes excluding the removal of the t.Parallel from `cron_test.go`. Some fixes like ```go assert.True(t, len(pods.Items) > 0, "pod was not created successfully") ``` went to ```go assert.Positive(t, pods.Items, "pod was not created successfully") ``` and I have manually converted these to ```go assert.NotEmpty(t, pods.Items, "pod was not created successfully") ``` `test/e2e/agent_test.go` also needed `0`->`time.Duration(0)` for one `assert.Equal`. Signed-off-by: Alan Clucas <[email protected]>
Joibel
force-pushed
the
testifylint-automated-fix
branch
from
fcdc510 to
879d23a
Compare
agilgur5
changed the title
agilgur5
approved these changes
Jul 27, 2024
Switching it on is as simple as adding it to --- a/.golangci.yml
+++ b/.golangci.yml
@@ -33,6 +33,7 @@ linters:
- rowserrcheck
- sqlclosecheck
- staticcheck
+ - testifylint
- typecheck
- unparam
- unusedThe remaining work (outside of all the require PRs) is:
The temporary downside is that merged PRs from CI that happened before the linter enablement may fail the linter after merge. We'll just have to deal with it as it happens. |
could also temporarily add a lint ignore
You mentioned |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of a series of test tidies started by #13365.
The aim is to enable the testifylint golangci-lint checker.
This patch is just the automated fixes (
testifylint --fix) excluding the removal of thet.Parallelfromcron_test.go.Some fixes like
went to
and I have manually converted these to
test/e2e/agent_test.goalso needed0->time.Duration(0)for oneassert.Equal.Note to maintainers: Please feel free to apply fixes yourself to this PR