-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps)!: bump k8s dependencies to 1.30 #13413
Merged
Merged
Changes from 5 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
829516a
chore(deps)!: bump k8s dependencies to 1.30
blkperl c53dd4f
test: fix test
blkperl 3046f1f
chore: fix codegen
blkperl 1180f80
chore: whitespace
blkperl 367a37a
test: fix contains in metric test
blkperl 80eee55
Merge remote-tracking branch 'origin/main' into k8s_1.30
blkperl 1a0a0dc
fix: lint
blkperl 5d49047
fix: lint
blkperl d460ef2
Merge branch 'main' into k8s_1.30
blkperl 38a1494
Merge remote-tracking branch 'origin/main' into k8s_1.30
blkperl e56e4af
Merge remote-tracking branch 'github/k8s_1.30' into k8s_1.30
blkperl 5ae2e7a
fix: merge conflict
blkperl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -288,11 +288,13 @@ endif | |
$(GOPATH)/bin/controller-gen: | ||
# update this in Nix when upgrading it here | ||
ifneq ($(USE_NIX), true) | ||
go install sigs.k8s.io/controller-tools/cmd/controller-gen@v0.14.0 | ||
go install sigs.k8s.io/controller-tools/cmd/controller-gen@v0.15.0 | ||
endif | ||
$(GOPATH)/bin/go-to-protobuf: | ||
# update this in Nix when upgrading it here | ||
ifneq ($(USE_NIX), true) | ||
# TODO: currently fails on v0.30.3 with | ||
# Unable to clean package k8s.io.api.core.v1: remove /home/runner/go/pkg/mod/k8s.io/[email protected]/core/v1/generated.proto: permission denied | ||
go install k8s.io/code-generator/cmd/[email protected] | ||
endif | ||
$(GOPATH)/src/github.com/gogo/protobuf: | ||
|
@@ -623,7 +625,7 @@ pkg/apis/workflow/v1alpha1/zz_generated.deepcopy.go: $(TYPES) | |
|
||
dist/kubernetes.swagger.json: | ||
@mkdir -p dist | ||
./hack/recurl.sh dist/kubernetes.swagger.json https://raw.githubusercontent.com/kubernetes/kubernetes/v1.23.3/api/openapi-spec/swagger.json | ||
./hack/recurl.sh dist/kubernetes.swagger.json https://raw.githubusercontent.com/kubernetes/kubernetes/v1.30.3/api/openapi-spec/swagger.json | ||
|
||
pkg/apiclient/_.secondary.swagger.json: hack/api/swagger/secondaryswaggergen.go pkg/apis/workflow/v1alpha1/openapi_generated.go dist/kubernetes.swagger.json | ||
rm -Rf v3 vendor | ||
|
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What package is this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what you mean. It fails to
make pre-commit -B
when I bump the version for this go install