chore(deps): bump golangci-lint from 1.55.1 to 1.59.1
#13473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golangci-lint 1.60.1 was released yesterday, but that bumps govet causing some hard to resolve errors. I'll wait for the dust to settle on that before attempting the update. gosimple: fixes to `server/auth/sso/sso.go` `S1009: should omit nil check; len() for []string is defined as zero (gosimple)` testifylint: undo assert->require changes in functions where they won't work correctly `go-require: do not use require in http handlers (testifylint)` `go-require: require must only be used in the goroutine running the test function (testifylint)` Signed-off-by: Alan Clucas <[email protected]>
Joibel
force-pushed
the
golangci-lint-bump
branch
from
6010a6c to
eeade18
Compare
Joibel
changed the title
Joibel
changed the title
golangci-lint from 1.55.1 to 1.59.1
Joibel
added
type/dependencies
interesting, if i'm understanding correctly, these are both for when concurrency is happening so the exit of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#13467 enabled testifylint, but the results weren't quite lining up with my expectations, so I'd suggested bumping the linter version. This PR does that.
golangci-lint 1.60.1 was released yesterday, but that bumps govet causing some hard to resolve errors. I'll wait for the dust to settle on that before attempting that update.
gosimple: fixes to
server/auth/sso/sso.goS1009: should omit nil check; len() for []string is defined as zero (gosimple)testifylint: undo assert->require changes in functions where they won't work correctly
go-require: do not use require in http handlers (testifylint)go-require: require must only be used in the goroutine running the test function (testifylint)