feat(ui): Make URLs clickable in workflow node info #13494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agilgur5
changed the title
agilgur5
reviewed
Aug 22, 2024
| @@ -68,10 +69,40 @@ interface Props { | |||
| onResume?: () => void; | |||
| } | |||
|
|
|||
| const linkify = new LinkifyIt(); | |||
|
|
|||
| function linkifyText(text: string) { | |||
There was a problem hiding this comment.
This should probably be a util function given that it's likely to be used in other places.
That also raises the question: is this the only place we'd add this? Does this open too many floodgates?
There was a problem hiding this comment.
No you're right we could definitely use this in other places, can't see where atm but I'll make it easily reusable
|
do u think same approach would work on #13148 ? |
|
No, since that uses a terminal with |
Adrien-D
force-pushed
the
output-parameter-clickable
branch
from
cd6a765 to
661cb79
Compare
Signed-off-by: Adrien Delannoy <[email protected]>
Signed-off-by: Adrien Delannoy <[email protected]>
Adrien-D
force-pushed
the
output-parameter-clickable
branch
from
661cb79 to
511acae
Compare
Adrien-D
added a commit
to pipekit/argo-workflows
that referenced
this pull request
Nov 26, 2024
Signed-off-by: Adrien Delannoy <[email protected]>
Joibel
pushed a commit
to Joibel/argo-workflows
that referenced
this pull request
Dec 5, 2024
Signed-off-by: Adrien Delannoy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No linked issue as it's a very small quick win, not sure it needs discussions
Motivation
In workflow node details we may have templates that output links to other systems or other workflows. So that would be great to make navigation easier by showing links instead of text.
Modifications
I implemented
linkify-itlibrary to find url matches and wrap those in a link tag.Verification
I tested of several workflow to make sure everything is fine