refactor: separate metrics code for reuse #13514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joibel
force-pushed
the
telemetry-refactor
branch
6 times, most recently
from
4c980f2 to
c4c52e2
Compare
This PR is intended as a pure refactor to move code. It separates the reusable metrics code into something that could be reused in a separate module. This intention is proved in a separate PR which adds metrics to the server. The `version` metric is moved to also be reusable as it is simple and obvious to be reused in the server. Labels are renamed to Attrib(utes) to match OpenTelemetry. Signed-off-by: Alan Clucas <[email protected]>
Joibel
force-pushed
the
telemetry-refactor
branch
from
c4c52e2 to
33d9159
Compare
isubasinghe
requested changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended as a pure refactor to move code.
It separates the reusable metrics code into something that could be reused in a separate module.
This intention is proved in a separate PR which adds metrics to the server. #13515 should be used as a reference for how this would work.
The
versionmetric is moved to also be reusable as it is simple and obvious to be reused in the server.Labels are renamed to Attributes as per OpenTelemetry.