Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(artifacts): notate OSS as streaming capable in v3.6+ #13582

Merged
merged 1 commit into from
Sep 10, 2024
Merged

docs(artifacts): notate OSS as streaming capable in v3.6+ #13582

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/configure-artifact-repository.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -623,7 +623,7 @@ configuring the default artifact repository described previously.
## Artifact Streaming

With artifact streaming, artifacts don’t need to be saved to disk first. Artifact streaming is only supported in the following
artifact drivers: S3 (v3.4+), Azure Blob (v3.4+), HTTP (v3.5+), and Artifactory (v3.5+).
artifact drivers: S3 (v3.4+), Azure Blob (v3.4+), HTTP (v3.5+), Artifactory (v3.5+), and OSS (v3.6+).
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should probably change this to a table given there's 5+ drivers here now

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or add "Streaming" to the top level table on this page. Which might be a bit dated too as well

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This whole page probably wants some effort putting in. This was a minimum update just for correctness.

Copy link

@agilgur5 agilgur5 Sep 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh for sure, I've been gradually reviewing large pieces of it in PRs (#13376 and #12467 (review)).
Also the general page on using artifacts (vs configuring the artifact repo) is one of the docs pages that needs the most work 😅 (I actually have changes to it dating back probably 10+ months ago, but kept finding more and more things to fix 🫠 )

This was a minimum update just for correctness.

I did approve the PR as well, i.e. making this comment optional


Previously, when a user would click the button to download an artifact in the UI, the artifact would need to be written to the
Argo Server’s disk first before downloading. If many users tried to download simultaneously, they would take up
Expand Down
Loading