-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use container name as archive log key #13597
Open
chengjoey
wants to merge
1
commit into
argoproj:main
Choose a base branch
from
chengjoey:feat/container-log
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agilgur5
changed the title
feat: use container name as artifact-log`s name/key
feat: use container name as archive log key
Sep 14, 2024
chengjoey
force-pushed
the
feat/container-log
branch
from
September 17, 2024 13:05
e6ea5b5
to
fe051f4
Compare
6 tasks
shuangkun
approved these changes
Nov 2, 2024
shuangkun
reviewed
Nov 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (!isPendingOrRunning && hasArtifactLogs(workflow, nodeId, container) && container === 'main') { |
Remove the restriction of this main container? And fix this problem at the same time. #13785
4 tasks
Signed-off-by: joey <[email protected]>
chengjoey
force-pushed
the
feat/container-log
branch
from
November 3, 2024 14:32
fe051f4
to
dae8a25
Compare
done |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13590
Motivation
if tmpl type is
Container
and container.Name not empty, use container name as artifact log file nameVerification
e2e test