Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use container name as archive log key #13597

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

chengjoey
Copy link
Contributor

@chengjoey chengjoey commented Sep 14, 2024

Fixes #13590

Motivation

if tmpl type is Container and container.Name not empty, use container name as artifact log file name

Verification

e2e test

@agilgur5 agilgur5 changed the title feat: use container name as artifact-log`s name/key feat: use container name as archive log key Sep 14, 2024
@agilgur5 agilgur5 added the area/archive-logs Archive Logs feature label Sep 14, 2024
Copy link
Member

@shuangkun shuangkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if (!isPendingOrRunning && hasArtifactLogs(workflow, nodeId, container) && container === 'main') {

Remove the restriction of this main container? And fix this problem at the same time. #13785

@chengjoey
Copy link
Contributor Author

if (!isPendingOrRunning && hasArtifactLogs(workflow, nodeId, container) && container === 'main') {

Remove the restriction of this main container? And fix this problem at the same time. #13785

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/archive-logs Archive Logs feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use container name if supplied in archive logs
4 participants