chore: update golangci-lint to v1.61.0 #13602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: william.vanhevelingen <[email protected]>
Signed-off-by: william.vanhevelingen <[email protected]>
agilgur5
added
type/dependencies
isubasinghe
added
the
prioritized-review
|
I believe this fixes memory usage issues, currently occasionally hit 84gb of memory usage before OOM. |
Which part fixes that? |
|
The newer version of golangci-lint |
|
Oh, during linting, not at runtime. More coffee needed. Ok - I remember you saying it did mad things for you. |
Joibel
approved these changes
Sep 16, 2024
| @@ -43,7 +43,6 @@ func (s *CronSuite) TearDownSuite() { | |||
|
|
|||
| func (s *CronSuite) TestBasic() { | |||
| s.Run("TestBasic", func() { | |||
| s.T().Parallel() | |||
There was a problem hiding this comment.
These don't do anything, and as this was the only attempt in the code to parallelise tests, we could remove the -parallel flag on the test suite.
I'd like to find a way to reintroduce parallel testing in the future though, so let's not do that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Modifications
Changed
exportloopreftocopyloopvarFixed the following lint errors
printf: non-constant format string in call to github.com/sirupsen/logrus.Infofprintf: non-constant format string in call to (*testing.common).Fatalf (govet)printf: non-constant format string in call to fmt.Sprintf (govet)printf: non-constant format string in call to google.golang.org/grpc/status.Errorf (govet)suite-broken-parallel: testify v1 does not support suite's parallel tests and subtestssuite-subtest-run: use s.Run to run subtest (testifylint)The copy of the 'for' variable "limit" can be deleted (Go 1.22+) (copyloopvar)Verification
Lint passes and existing test coverage