Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(contrib): remove outdated section on using multiple terminals #13604

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

MasonM
Copy link
Contributor

@MasonM MasonM commented Sep 15, 2024

Motivation

I noticed the CTRL variable was deleted in #10599 and now does nothing, so I figured it's best to delete this section to avoid confusion. This has confused one other contributor before in #11879 (comment):

I don't think using one terminal for the controller + server and another for the UI works.... I'm not seeing any reference to CTRL in the make file. When I try to run the command for starting the UI alone (make start CTRL=false) fails since it tries to boot up the controller again (it is already running).

Modifications

Delete outdated section

Verification

N/A

I noticed the `CTRL` variable was deleted in
05e1318 and now does nothing, so I
figured it's best to delete this section to avoid confusion.

Signed-off-by: Mason Malone <[email protected]>
@MasonM MasonM marked this pull request as ready for review September 15, 2024 20:55
@Joibel
Copy link
Member

Joibel commented Sep 16, 2024

I don't think CTRL was ever implemented for kit.

For anyone who comes across this PR and feels like re-implementing CTRL, I'm not against having it. As we've lived without it for a while I'll merge this

@Joibel Joibel merged commit c1c1c53 into argoproj:main Sep 16, 2024
16 checks passed
@agilgur5 agilgur5 added area/docs Incorrect, missing, or mistakes in docs area/contributing Contributing docs, ownership, etc. Also devtools like devcontainer and Nix labels Sep 17, 2024
@MasonM MasonM deleted the fix-docs branch September 17, 2024 15:13
Joibel pushed a commit to pipekit/argo-workflows that referenced this pull request Sep 19, 2024
Joibel pushed a commit that referenced this pull request Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/contributing Contributing docs, ownership, etc. Also devtools like devcontainer and Nix area/docs Incorrect, missing, or mistakes in docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants