ci: increase timeout for e2e-tests #13769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Occasionally, tests are being canceled due to exceeding the 30 minute timeout. Example: https://github.com/argoproj/argo-workflows/actions/runs/11358993638/job/31594490093 While there are optimizations we can make to the test suite to mitigate this, sometimes resource contention causes things to slow to a crawl for reasons outside our control. In the example above, it spent 9m15s on "Free up unused disk space" step, which normally takes ~12s. The only thing that step is doing is running `rm -rf`. This removes the timeout so it uses the default of 360 minutes (source: https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#jobsjob_idtimeout-minutes). This is what ArgoCD does (source: https://github.com/argoproj/argo-cd/blob/049ba0aab3965f3fa73447ae2db08f3a2afd95a0/.github/workflows/ci-build.yaml#L398), and E2E tests for ArgoCD PRs often take ~1hour (example: https://github.com/argoproj/argo-cd/actions/runs/11352918460/job/31576914061). Signed-off-by: Mason Malone <[email protected]>
MasonM
changed the title
agilgur5
changed the title
Joibel
requested changes
Oct 17, 2024
Signed-off-by: Mason Malone <[email protected]>
Joibel
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix for #10807
Motivation
Occasionally, tests are being canceled due to exceeding the 30 minute timeout. Example: https://github.com/argoproj/argo-workflows/actions/runs/11358993638/job/31594490093
While there are optimizations we can make to the test suite to mitigate this, sometimes resource contention causes things to slow to a crawl for reasons outside our control. In the example above, it spent 9m15s on "Free up unused disk space", which normally takes ~12s. The only thing that step is doing is running
rm -rf, so that indicates extremely high I/O contention on the runner.Modifications
This removes the timeout so it uses the default of 360 minutes (docs). This is what ArgoCD does (source), and E2E tests for ArgoCD PRs often take ~50 minutes (example).
Verification
Wait for actions to run