feat(ui): option to disable workflow editor (#11391) #13840
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As discussed by agilgur5 in #11391 this doesn't prevent submission of arbitrary workflows and there is already a mechanism that does. |
|
templateReferencing is too basic, doesn't allow certain superusers to not use template ie via cli |
MasonM
reviewed
Oct 31, 2024
| @@ -21,6 +21,7 @@ export function WorkflowCreator({namespace, onCreate}: {namespace: string; onCre | |||
| const [stage, setStage] = useState<Stage>('choose-method'); | |||
| const [workflow, setWorkflow] = useState<Workflow>(); | |||
| const [error, setError] = useState<Error>(); | |||
| const isFullEditorDisabled = process.env.UI_DISABLE_FULL_EDITOR === 'true'; | |||
There was a problem hiding this comment.
Unfortunately, this isn't going to work, because this file is executed by the browser, and process is only valid in a NodeJS context. There's no way for the browser to know what environment variables are defined at the server level without an API call.
How did you test this? I ask because you should have seen a "process is not defined" error immediately on loading the workflow creator. If you didn't see an error, then something is probably wrong with your local environment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11391