Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Move contextless log messages to debug logging - fixes #13918 #13920

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

kizzie
Copy link
Contributor

@kizzie kizzie commented Nov 19, 2024

Fixes #13918

Motivation

'node changed' 'node unchanged' and 'task-result changed' flood the logs when running argo in production with many workflows and parallel runs, move these log statements to debug logging so that we can filter them

Modifications

Change logging for those three statements from Info to Debug

Verification

Run the tests. Log messages should be being logged as debug instead of info

@kizzie kizzie changed the title feat: Move contextless log messages to debug logging feat: Move contextless log messages to debug logging - fixes #1391 Nov 19, 2024
'node changed' 'node unchanged' and 'task-result changed' flood
the logs when running argo in production with many workflows and
parallel runs, move these log statements to debug logging so
that we can filter them

Signed-off-by: kizzie <[email protected]>
@kizzie kizzie force-pushed the feature/use-debug-logging branch from f4bb2f6 to 9641cea Compare November 19, 2024 16:39
@kizzie kizzie changed the title feat: Move contextless log messages to debug logging - fixes #1391 feat: Move contextless log messages to debug logging - fixes #13918 Nov 19, 2024
@kizzie kizzie marked this pull request as ready for review November 25, 2024 17:07
Copy link
Member

@Joibel Joibel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Kat, LGTM

@Joibel Joibel merged commit 1f304ba into argoproj:main Nov 28, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move some of the contextless log messages to debug level logging
2 participants