fix(ui): Clickable URLs are messing up formatting in the UI #13923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adrien Delannoy <[email protected]>
Joibel
pushed a commit
that referenced
this pull request
Nov 22, 2024
Signed-off-by: Adrien Delannoy <[email protected]> (cherry picked from commit eb4f245)
Adrien-D
added a commit
to pipekit/argo-workflows
that referenced
this pull request
Nov 26, 2024
Signed-off-by: Adrien Delannoy <[email protected]>
Joibel
pushed a commit
to Joibel/argo-workflows
that referenced
this pull request
Dec 5, 2024
Signed-off-by: Adrien Delannoy <[email protected]>
Joibel
pushed a commit
to Joibel/argo-workflows
that referenced
this pull request
Dec 6, 2024
…#13923) (argoproj#34) Signed-off-by: Adrien Delannoy <[email protected]> Co-authored-by: Adrien Delannoy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Since this change, URLs are now clickable but splitted in columns which is not the desired behavior
Modifications
I wrapped the
LinkifiedTextcomponent with a simple span to leave the text on the same lineVerification