Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Fixed broken bash script when installing on macos #13981

Merged
merged 1 commit into from
Dec 12, 2024
Merged

docs: Fixed broken bash script when installing on macos #13981

merged 1 commit into from
Dec 12, 2024
+1 −1

Conversation

htquanq
Copy link
Contributor

@htquanq htquanq commented Dec 10, 2024

This is how I fixed bash script installing using cURL on my macbook.

@htquanq htquanq mentioned this pull request Dec 10, 2024
Closed
@htquanq htquanq changed the title Fixed broken bash script when installing on macos docs: Fixed broken bash script when installing on macos Dec 10, 2024
MasonM
MasonM approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@MasonM MasonM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The failing DCO check is because the commit wasn't signed off. You should be able to fix that with these commands:

git commit --signoff --amend
git push --force

terrytangyuan
terrytangyuan approved these changes Dec 12, 2024
View reviewed changes
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once DCO check is fixed

@htquanq
Copy link
Contributor Author

htquanq commented Dec 12, 2024

Hello guys, I have signed off commits

@terrytangyuan terrytangyuan merged commit ad994b4 into argoproj:main Dec 12, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terrytangyuan terrytangyuan terrytangyuan approved these changes

@MasonM MasonM MasonM approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@htquanq @MasonM @terrytangyuan