feat: customize nav bar background color #7387

krrrr38 · 2021-12-12T08:33:44Z

Signed-off-by: krrrr38 [email protected]

Run make pre-commit -B to fix codegen, lint, and commit message problems.

Motivation

I want to distinguish multiple argo-workflows easily not to operate invalid operation on different environments.

Fixes #1451

How to solve

Make argo-ui NavBar customizable to change nav bar style
- feat: customize nav bar background color style argo-ui#167
Add navigation bar background color configuration into argo-workflow config map
Pass background color info from GetInfo api

Discussions

There are some discussions about this feature.

argo-cd way customize css impl on argo-workflows
argo-workflows should provide argo-workflow way.
- customize css sometimes breaks the ui, so provide argo-workflow theme and css maintained by argo
More pluggable styles

To archive my goal, I add nav bar color config for following reasons.

argo-ui v2 has theme feature which support only dark or style
- this theme feature doesn't enough to distinguish multiple environments
When using theme, to distinguish multiple environments, we need to provides 3?, 4?,... themes. (dev, stg, prd, e2e, x division? x teams?,...)
- I have no skills to create new design argo themes..., but color settings are available too many colors and easy to distinguish.
pluggable ui and nav bar background color are something different.
- pluggable ui provides new feature which provides new component in specific domains.
  - (if this is not, sorry 🙇 )
- nav bar background color is global settings which is useful to distinguish multiple environments
Not to customize too many css, just add a color setting.

So, I add nav bar background color as global argo-workflow ui config. I hope this ui config might be support icon, title, and so on.

Check

#7387 (comment)

Signed-off-by: krrrr38 <[email protected]>

krrrr38 · 2021-12-12T08:55:26Z

CI / UI failed because this feature requires argoproj/argo-ui#167.

simster7 · 2021-12-13T15:45:41Z

pkg/apis/workflow/v1alpha1/info.go

+type Ui struct {
+	// NavColor is an ui navigation bar theme which switch the design
+	NavColor string `json:"navColor,omitempty" protobuf:"bytes,1,opt,name=navColor"`
+}


If anything, wouldn't it be more powerful to allow a way to inject CSS overrides?

Based on the descriptionDiscussions, I think this way is better.

alexec

The use case for this are pretty simple, the ability to set colour differently for different environments. I think this is probably good enough for that. Previous solutions have been, these have been complex, I like the simplicity

pkg/apis/workflow/v1alpha1/info.go

Signed-off-by: krrrr38 <[email protected]>

alexec

I don't think we actually need the "UI" wrapper, as we already have links top-level. Can just be info.navColor

krrrr38 · 2021-12-14T00:14:53Z

I don't think we actually need the "UI" wrapper, as we already have links top-level. Can just be info.navColor

I also worry about this. I'll remove ui wrapper

Signed-off-by: krrrr38 <[email protected]>

krrrr38 · 2021-12-14T01:14:01Z

re-confirmed that nav bar color was changed by following config map

> kubectl get cm -n argo workflow-controller-configmap -ojsonpath='{.data.navColor}'
red

Again, this feature requires argoproj/argo-ui#167 change.

alexec

Please fix build.

krrrr38 · 2022-01-18T21:21:48Z

@alexec thank you for your review.
To build this PR, it requires argo-ui changes.
Can anyone review argoproj/argo-ui#167?

alexec · 2022-01-19T15:34:50Z

Up-stream PR now merged, you should. be able to use argo-ui version v2.5.0.

Signed-off-by: krrrr38 <[email protected]>

krrrr38 · 2022-01-19T23:36:13Z

I tried yarn upgrade argo-ui@"https://github.com/argoproj/argo-ui.git", but there are some errors which depends on other library updates.
It seems that we need to upgrade rxjs5.x -> 6.x. I will create another PR to upgrade argo-ui.

`yarn upgrade argo-ui@"https://github.com/argoproj/argo-ui.git && yarn build` errors

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/event-flow/components/event-flow-details/event-flow-page.tsx
./src/app/event-flow/components/event-flow-details/event-flow-page.tsx
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/event-flow/components/event-flow-details/event-flow-page.tsx(168,23)
      TS2339: Property 'eventSourceName' does not exist on type 'unknown'.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/event-flow/components/event-flow-details/event-flow-page.tsx
./src/app/event-flow/components/event-flow-details/event-flow-page.tsx
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/event-flow/components/event-flow-details/event-flow-page.tsx(169,58)
      TS2339: Property 'namespace' does not exist on type 'unknown'.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/event-flow/components/event-flow-details/event-flow-page.tsx
./src/app/event-flow/components/event-flow-details/event-flow-page.tsx
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/event-flow/components/event-flow-details/event-flow-page.tsx(169,71)
      TS2339: Property 'eventSourceName' does not exist on type 'unknown'.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/event-flow/components/event-flow-details/event-flow-page.tsx
./src/app/event-flow/components/event-flow-details/event-flow-page.tsx
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/event-flow/components/event-flow-details/event-flow-page.tsx(169,90)
      TS2339: Property 'eventName' does not exist on type 'unknown'.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/event-flow/components/event-flow-details/event-flow-page.tsx
./src/app/event-flow/components/event-flow-details/event-flow-page.tsx
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/event-flow/components/event-flow-details/event-flow-page.tsx(185,49)
      TS2339: Property 'namespace' does not exist on type 'unknown'.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/event-flow/components/event-flow-details/event-flow-page.tsx
./src/app/event-flow/components/event-flow-details/event-flow-page.tsx
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/event-flow/components/event-flow-details/event-flow-page.tsx(185,62)
      TS2339: Property 'sensorName' does not exist on type 'unknown'.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/event-flow/components/event-flow-details/event-flow-page.tsx
./src/app/event-flow/components/event-flow-details/event-flow-page.tsx
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/event-flow/components/event-flow-details/event-flow-page.tsx(186,23)
      TS2339: Property 'triggerName' does not exist on type 'unknown'.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/event-flow/components/event-flow-details/event-flow-page.tsx
./src/app/event-flow/components/event-flow-details/event-flow-page.tsx
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/event-flow/components/event-flow-details/event-flow-page.tsx(187,54)
      TS2339: Property 'namespace' does not exist on type 'unknown'.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/event-flow/components/event-flow-details/event-flow-page.tsx
./src/app/event-flow/components/event-flow-details/event-flow-page.tsx
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/event-flow/components/event-flow-details/event-flow-page.tsx(187,67)
      TS2339: Property 'sensorName' does not exist on type 'unknown'.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/event-flow/components/event-flow-details/event-flow-page.tsx
./src/app/event-flow/components/event-flow-details/event-flow-page.tsx
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/event-flow/components/event-flow-details/event-flow-page.tsx(187,81)
      TS2339: Property 'triggerName' does not exist on type 'unknown'.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/event-flow/components/event-flow-details/event-flow-page.tsx
./src/app/event-flow/components/event-flow-details/event-flow-page.tsx
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/event-flow/components/event-flow-details/event-flow-page.tsx(328,62)
      TS2339: Property 'filter' does not exist on type 'Observable<any>'.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/event-flow/components/event-flow-details/event-flow-page.tsx
./src/app/event-flow/components/event-flow-details/event-flow-page.tsx
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/event-flow/components/event-flow-details/event-flow-page.tsx(328,69)
      TS7006: Parameter 'e' implicitly has an 'any' type.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/event-flow/components/event-flow-details/event-flow-page.tsx
./src/app/event-flow/components/event-flow-details/event-flow-page.tsx
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/event-flow/components/event-flow-details/event-flow-page.tsx(330,65)
      TS7006: Parameter 'e' implicitly has an 'any' type.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/event-sources/components/event-source-log-viewer.tsx
./src/app/event-sources/components/event-source-log-viewer.tsx
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/event-sources/components/event-source-log-viewer.tsx(37,21)
      TS7006: Parameter 'e' implicitly has an 'any' type.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/event-sources/components/event-source-log-viewer.tsx
./src/app/event-sources/components/event-source-log-viewer.tsx
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/event-sources/components/event-source-log-viewer.tsx(39,17)
      TS7006: Parameter 'e' implicitly has an 'any' type.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/pipelines/components/pipeline-logs-viewer.tsx
./src/app/pipelines/components/pipeline-logs-viewer.tsx
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/pipelines/components/pipeline-logs-viewer.tsx(31,21)
      TS7006: Parameter 'e' implicitly has an 'any' type.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/pipelines/components/pipeline-logs-viewer.tsx
./src/app/pipelines/components/pipeline-logs-viewer.tsx
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/pipelines/components/pipeline-logs-viewer.tsx(32,18)
      TS7006: Parameter 'e' implicitly has an 'any' type.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/pipelines/components/pipeline-logs-viewer.tsx
./src/app/pipelines/components/pipeline-logs-viewer.tsx
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/pipelines/components/pipeline-logs-viewer.tsx(34,18)
      TS7006: Parameter 'x' implicitly has an 'any' type.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/pipelines/components/pipeline-logs-viewer.tsx
./src/app/pipelines/components/pipeline-logs-viewer.tsx
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/pipelines/components/pipeline-logs-viewer.tsx(34,56)
      TS7006: Parameter 'y' implicitly has an 'any' type.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/sensors/components/sensor-logs-viewer.tsx
./src/app/sensors/components/sensor-logs-viewer.tsx
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/sensors/components/sensor-logs-viewer.tsx(37,21)
      TS7006: Parameter 'e' implicitly has an 'any' type.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/sensors/components/sensor-logs-viewer.tsx
./src/app/sensors/components/sensor-logs-viewer.tsx
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/sensors/components/sensor-logs-viewer.tsx(39,17)
      TS7006: Parameter 'e' implicitly has an 'any' type.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/shared/utils.ts
./src/app/shared/utils.ts
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/shared/utils.ts(39,62)
      TS2339: Property 'catch' does not exist on type 'Observable<T>'.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/shared/utils.ts
./src/app/shared/utils.ts
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/shared/utils.ts(42,27)
      TS2339: Property 'from' does not exist on type 'typeof Observable'.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/shared/components/dropdown/dropdown.tsx
./src/app/shared/components/dropdown/dropdown.tsx
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/shared/components/dropdown/dropdown.tsx(70,24)
      TS2339: Property 'merge' does not exist on type 'typeof Observable'.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/shared/components/dropdown/dropdown.tsx
./src/app/shared/components/dropdown/dropdown.tsx
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/shared/components/dropdown/dropdown.tsx(71,32)
      TS2339: Property 'filter' does not exist on type 'BehaviorSubject<DropDown>'.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/shared/components/dropdown/dropdown.tsx
./src/app/shared/components/dropdown/dropdown.tsx
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/shared/components/dropdown/dropdown.tsx(71,39)
      TS7006: Parameter 'dropdown' implicitly has an 'any' type.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/shared/components/dropdown/dropdown.tsx
./src/app/shared/components/dropdown/dropdown.tsx
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/shared/components/dropdown/dropdown.tsx(72,28)
      TS2339: Property 'fromEvent' does not exist on type 'typeof Observable'.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/shared/components/dropdown/dropdown.tsx
./src/app/shared/components/dropdown/dropdown.tsx
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/shared/components/dropdown/dropdown.tsx(78,24)
      TS2339: Property 'fromEvent' does not exist on type 'typeof Observable'.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/shared/services/event-source-service.ts
./src/app/shared/services/event-source-service.ts
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/shared/services/event-source-service.ts(32,85)
      TS2339: Property 'map' does not exist on type 'Observable<string>'.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/shared/services/event-source-service.ts
./src/app/shared/services/event-source-service.ts
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/shared/services/event-source-service.ts(32,89)
      TS7006: Parameter 'line' implicitly has an 'any' type.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/shared/services/event-source-service.ts
./src/app/shared/services/event-source-service.ts
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/shared/services/event-source-service.ts(52,110)
      TS2339: Property 'map' does not exist on type 'Observable<string>'.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/shared/services/event-source-service.ts
./src/app/shared/services/event-source-service.ts
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/shared/services/event-source-service.ts(52,114)
      TS7006: Parameter 'line' implicitly has an 'any' type.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/shared/services/pipeline-service.ts
./src/app/shared/services/pipeline-service.ts
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/shared/services/pipeline-service.ts(12,81)
      TS2339: Property 'map' does not exist on type 'Observable<string>'.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/shared/services/pipeline-service.ts
./src/app/shared/services/pipeline-service.ts
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/shared/services/pipeline-service.ts(12,85)
      TS7006: Parameter 'line' implicitly has an 'any' type.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/shared/services/pipeline-service.ts
./src/app/shared/services/pipeline-service.ts
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/shared/services/pipeline-service.ts(32,106)
      TS2339: Property 'map' does not exist on type 'Observable<string>'.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/shared/services/pipeline-service.ts
./src/app/shared/services/pipeline-service.ts
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/shared/services/pipeline-service.ts(32,110)
      TS7006: Parameter 'line' implicitly has an 'any' type.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/shared/services/pipeline-service.ts
./src/app/shared/services/pipeline-service.ts
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/shared/services/pipeline-service.ts(49,14)
      TS2339: Property 'map' does not exist on type 'Observable<string>'.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/shared/services/pipeline-service.ts
./src/app/shared/services/pipeline-service.ts
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/shared/services/pipeline-service.ts(49,18)
      TS7006: Parameter 'line' implicitly has an 'any' type.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/shared/services/sensor-service.ts
./src/app/shared/services/sensor-service.ts
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/shared/services/sensor-service.ts(32,79)
      TS2339: Property 'map' does not exist on type 'Observable<string>'.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/shared/services/sensor-service.ts
./src/app/shared/services/sensor-service.ts
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/shared/services/sensor-service.ts(32,83)
      TS7006: Parameter 'line' implicitly has an 'any' type.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/shared/services/sensor-service.ts
./src/app/shared/services/sensor-service.ts
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/shared/services/sensor-service.ts(49,104)
      TS2339: Property 'map' does not exist on type 'Observable<string>'.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/shared/services/sensor-service.ts
./src/app/shared/services/sensor-service.ts
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/shared/services/sensor-service.ts(49,108)
      TS7006: Parameter 'line' implicitly has an 'any' type.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/shared/services/workflows-service.ts
./src/app/shared/services/workflows-service.ts
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/shared/services/workflows-service.ts(60,46)
      TS2339: Property 'map' does not exist on type 'Observable<string>'.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/shared/services/workflows-service.ts
./src/app/shared/services/workflows-service.ts
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/shared/services/workflows-service.ts(60,50)
      TS7006: Parameter 'data' implicitly has an 'any' type.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/shared/services/workflows-service.ts
./src/app/shared/services/workflows-service.ts
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/shared/services/workflows-service.ts(64,121)
      TS2339: Property 'map' does not exist on type 'Observable<string>'.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/shared/services/workflows-service.ts
./src/app/shared/services/workflows-service.ts
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/shared/services/workflows-service.ts(64,125)
      TS7006: Parameter 'data' implicitly has an 'any' type.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/shared/services/workflows-service.ts
./src/app/shared/services/workflows-service.ts
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/shared/services/workflows-service.ts(93,46)
      TS2339: Property 'map' does not exist on type 'Observable<string>'.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/shared/services/workflows-service.ts
./src/app/shared/services/workflows-service.ts
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/shared/services/workflows-service.ts(93,50)
      TS7006: Parameter 'data' implicitly has an 'any' type.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/shared/services/workflows-service.ts
./src/app/shared/services/workflows-service.ts
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/shared/services/workflows-service.ts(140,14)
      TS2339: Property 'filter' does not exist on type 'Observable<string>'.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/shared/services/workflows-service.ts
./src/app/shared/services/workflows-service.ts
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/shared/services/workflows-service.ts(140,21)
      TS7006: Parameter 'line' implicitly has an 'any' type.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/shared/services/workflows-service.ts
./src/app/shared/services/workflows-service.ts
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/shared/services/workflows-service.ts(141,18)
      TS7006: Parameter 'line' implicitly has an 'any' type.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/shared/services/workflows-service.ts
./src/app/shared/services/workflows-service.ts
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/shared/services/workflows-service.ts(142,21)
      TS7006: Parameter 'e' implicitly has an 'any' type.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/shared/services/workflows-service.ts
./src/app/shared/services/workflows-service.ts
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/shared/services/workflows-service.ts(148,35)
      TS2339: Property 'fromPromise' does not exist on type 'typeof Observable'.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/shared/services/workflows-service.ts
./src/app/shared/services/workflows-service.ts
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/shared/services/workflows-service.ts(148,113)
      TS7006: Parameter 'isPendingOrRunning' implicitly has an 'any' type.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/shared/services/workflows-service.ts
./src/app/shared/services/workflows-service.ts
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/shared/services/workflows-service.ts(155,39)
      TS2339: Property 'empty' does not exist on type 'typeof Observable'.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/shared/services/workflows-service.ts
./src/app/shared/services/workflows-service.ts
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/shared/services/workflows-service.ts(172,27)
      TS2339: Property 'of' does not exist on type 'typeof Observable'.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/shared/services/workflows-service.ts
./src/app/shared/services/workflows-service.ts
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/shared/services/workflows-service.ts(173,24)
      TS7006: Parameter 'hasArtifactLogs' implicitly has an 'any' type.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/shared/services/workflows-service.ts
./src/app/shared/services/workflows-service.ts
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/shared/services/workflows-service.ts(178,35)
      TS2339: Property 'fromPromise' does not exist on type 'typeof Observable'.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/shared/services/workflows-service.ts
./src/app/shared/services/workflows-service.ts
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/shared/services/workflows-service.ts(180,23)
      TS7006: Parameter 'r' implicitly has an 'any' type.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/shared/services/workflows-service.ts
./src/app/shared/services/workflows-service.ts
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/shared/services/workflows-service.ts(181,18)
      TS7006: Parameter 'content' implicitly has an 'any' type.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/shared/services/workflows-service.ts
./src/app/shared/services/workflows-service.ts
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/shared/services/workflows-service.ts(182,21)
      TS7006: Parameter 'x' implicitly has an 'any' type.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/shared/services/workflows-service.ts
./src/app/shared/services/workflows-service.ts
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/shared/services/workflows-service.ts(194,27)
      TS2339: Property 'fromPromise' does not exist on type 'typeof Observable'.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/shared/services/workflows-service.ts
./src/app/shared/services/workflows-service.ts
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/shared/services/workflows-service.ts(194,104)
      TS7006: Parameter 'isPendingOrRunning' implicitly has an 'any' type.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/shared/services/workflows-service.ts
./src/app/shared/services/workflows-service.ts
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/shared/services/workflows-service.ts(198,89)
      TS2339: Property 'catch' does not exist on type 'Observable<LogEntry>'.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/workflows/components/events-panel.tsx
./src/app/workflows/components/events-panel.tsx
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/workflows/components/events-panel.tsx(34,74)
      TS2339: Property 'map' does not exist on type 'Observable<Event>'.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/workflows/components/events-panel.tsx
./src/app/workflows/components/events-panel.tsx
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/workflows/components/events-panel.tsx(35,21)
      TS7006: Parameter 'x' implicitly has an 'any' type.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/workflows/components/workflow-logs-viewer/workflow-logs-viewer.tsx
./src/app/workflows/components/workflow-logs-viewer/workflow-logs-viewer.tsx
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/workflows/components/workflow-logs-viewer/workflow-logs-viewer.tsx(41,14)
      TS2339: Property 'map' does not exist on type 'Observable<LogEntry>'.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/workflows/components/workflow-logs-viewer/workflow-logs-viewer.tsx
./src/app/workflows/components/workflow-logs-viewer/workflow-logs-viewer.tsx
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/workflows/components/workflow-logs-viewer/workflow-logs-viewer.tsx(41,18)
      TS7006: Parameter 'e' implicitly has an 'any' type.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/workflows/components/workflow-logs-viewer/workflow-logs-viewer.tsx
./src/app/workflows/components/workflow-logs-viewer/workflow-logs-viewer.tsx
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/workflows/components/workflow-logs-viewer/workflow-logs-viewer.tsx(43,18)
      TS7006: Parameter 'x' implicitly has an 'any' type.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/workflows/components/workflow-logs-viewer/workflow-logs-viewer.tsx
./src/app/workflows/components/workflow-logs-viewer/workflow-logs-viewer.tsx
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/workflows/components/workflow-logs-viewer/workflow-logs-viewer.tsx(45,61)
      TS7006: Parameter 'y' implicitly has an 'any' type.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/workflows/components/workflow-timeline/workflow-timeline.tsx
./src/app/workflows/components/workflow-timeline/workflow-timeline.tsx
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/workflows/components/workflow-timeline/workflow-timeline.tsx(38,46)
      TS2339: Property 'fromEvent' does not exist on type 'typeof Observable'.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/workflows/components/workflow-timeline/workflow-timeline.tsx
./src/app/workflows/components/workflow-timeline/workflow-timeline.tsx
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/src/app/workflows/components/workflow-timeline/workflow-timeline.tsx(137,51)
      TS2339: Property 'interval' does not exist on type 'typeof Observable'.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/src/components/nav-bar/nav-bar.tsx
./node_modules/argo-ui/src/components/nav-bar/nav-bar.tsx
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/src/components/nav-bar/nav-bar.tsx(30,25)
      TS2349: This expression is not callable.
  Type 'typeof import("/Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/node_modules/classnames/index")' has no call signatures.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/src/components/nav-bar/nav-bar.tsx
./node_modules/argo-ui/src/components/nav-bar/nav-bar.tsx
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/src/components/nav-bar/nav-bar.tsx(38,41)
      TS2349: This expression is not callable.
  Type 'typeof import("/Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/node_modules/classnames/index")' has no call signatures.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/src/components/page/page.tsx
./node_modules/argo-ui/src/components/page/page.tsx
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/src/components/page/page.tsx(3,24)
      TS7016: Could not find a declaration file for module 'react-helmet'. '/Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/react-helmet/lib/Helmet.js' implicitly has an 'any' type.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/src/components/page/page.tsx
./node_modules/argo-ui/src/components/page/page.tsx
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/src/components/page/page.tsx(29,25)
      TS2349: This expression is not callable.
  Type 'typeof import("/Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/node_modules/classnames/index")' has no call signatures.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/src/components/top-bar/top-bar.tsx
./node_modules/argo-ui/src/components/top-bar/top-bar.tsx
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/src/components/top-bar/top-bar.tsx(43,33)
      TS2349: This expression is not callable.
  Type 'typeof import("/Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/node_modules/classnames/index")' has no call signatures.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/src/components/top-bar/top-bar.tsx
./node_modules/argo-ui/src/components/top-bar/top-bar.tsx
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/src/components/top-bar/top-bar.tsx(49,36)
      TS2349: This expression is not callable.
  Type 'typeof import("/Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/node_modules/classnames/index")' has no call signatures.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/src/components/dropdown/dropdown.tsx
./node_modules/argo-ui/src/components/dropdown/dropdown.tsx
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/src/components/dropdown/dropdown.tsx(52,37)
      TS2349: This expression is not callable.
  Type 'typeof import("/Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/node_modules/classnames/index")' has no call signatures.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/src/components/tabs/tabs.tsx
./node_modules/argo-ui/src/components/tabs/tabs.tsx
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/src/components/tabs/tabs.tsx(53,33)
      TS2349: This expression is not callable.
  Type 'typeof import("/Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/node_modules/classnames/index")' has no call signatures.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/src/components/tabs/tabs.tsx
./node_modules/argo-ui/src/components/tabs/tabs.tsx
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/src/components/tabs/tabs.tsx(54,37)
      TS2349: This expression is not callable.
  Type 'typeof import("/Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/node_modules/classnames/index")' has no call signatures.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/src/components/tabs/tabs.tsx
./node_modules/argo-ui/src/components/tabs/tabs.tsx
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/src/components/tabs/tabs.tsx(55,41)
      TS2349: This expression is not callable.
  Type 'typeof import("/Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/node_modules/classnames/index")' has no call signatures.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/src/components/tabs/tabs.tsx
./node_modules/argo-ui/src/components/tabs/tabs.tsx
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/src/components/tabs/tabs.tsx(57,97)
      TS2349: This expression is not callable.
  Type 'typeof import("/Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/node_modules/classnames/index")' has no call signatures.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/src/components/tabs/tabs.tsx
./node_modules/argo-ui/src/components/tabs/tabs.tsx
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/src/components/tabs/tabs.tsx(62,45)
      TS2349: This expression is not callable.
  Type 'typeof import("/Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/node_modules/classnames/index")' has no call signatures.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/src/components/tabs/tabs.tsx
./node_modules/argo-ui/src/components/tabs/tabs.tsx
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/src/components/tabs/tabs.tsx(70,37)
      TS2349: This expression is not callable.
  Type 'typeof import("/Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/node_modules/classnames/index")' has no call signatures.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/src/components/sliding-panel/sliding-panel.tsx
./node_modules/argo-ui/src/components/sliding-panel/sliding-panel.tsx
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/src/components/sliding-panel/sliding-panel.tsx(19,21)
      TS2349: This expression is not callable.
  Type 'typeof import("/Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/node_modules/classnames/index")' has no call signatures.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/src/components/sliding-panel/sliding-panel.tsx
./node_modules/argo-ui/src/components/sliding-panel/sliding-panel.tsx
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/src/components/sliding-panel/sliding-panel.tsx(35,33)
      TS2349: This expression is not callable.
  Type 'typeof import("/Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/node_modules/classnames/index")' has no call signatures.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/src/components/popup/popup.tsx
./node_modules/argo-ui/src/components/popup/popup.tsx
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/src/components/popup/popup.tsx(33,33)
      TS2349: This expression is not callable.
  Type 'typeof import("/Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/node_modules/classnames/index")' has no call signatures.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/src/components/popup/popup.tsx
./node_modules/argo-ui/src/components/popup/popup.tsx
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/src/components/popup/popup.tsx(38,29)
      TS2349: This expression is not callable.
  Type 'typeof import("/Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/node_modules/classnames/index")' has no call signatures.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/src/components/popup/popup-manager.tsx
./node_modules/argo-ui/src/components/popup/popup-manager.tsx
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/src/components/popup/popup-manager.tsx(2,81)
      TS7016: Could not find a declaration file for module 'react-form'. '/Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/react-form/dist/index.js' implicitly has an 'any' type.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/src/components/popup/popup-manager.tsx
./node_modules/argo-ui/src/components/popup/popup-manager.tsx
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/src/components/popup/popup-manager.tsx(91,34)
      TS7006: Parameter 'api' implicitly has an 'any' type.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/src/components/popup/popup-manager.tsx
./node_modules/argo-ui/src/components/popup/popup-manager.tsx
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/src/components/popup/popup-manager.tsx(92,27)
      TS7006: Parameter 'api' implicitly has an 'any' type.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/src/components/select/select.tsx
./node_modules/argo-ui/src/components/select/select.tsx
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/src/components/select/select.tsx(88,33)
      TS2349: This expression is not callable.
  Type 'typeof import("/Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/node_modules/classnames/index")' has no call signatures.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/src/components/select/select.tsx
./node_modules/argo-ui/src/components/select/select.tsx
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/src/components/select/select.tsx(93,44)
      TS2349: This expression is not callable.
  Type 'typeof import("/Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/node_modules/classnames/index")' has no call signatures.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/src/components/form-field/form-field.tsx
./node_modules/argo-ui/src/components/form-field/form-field.tsx
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/src/components/form-field/form-field.tsx(3,28)
      TS7016: Could not find a declaration file for module 'react-form'. '/Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/react-form/dist/index.js' implicitly has an 'any' type.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/src/components/form-field/form-field.tsx
./node_modules/argo-ui/src/components/form-field/form-field.tsx
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/src/components/form-field/form-field.tsx(40,28)
      TS2349: This expression is not callable.
  Type 'typeof import("/Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/node_modules/classnames/index")' has no call signatures.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/src/components/form-field/form-field.tsx
./node_modules/argo-ui/src/components/form-field/form-field.tsx
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/src/components/form-field/form-field.tsx(55,25)
      TS2349: This expression is not callable.
  Type 'typeof import("/Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/node_modules/classnames/index")' has no call signatures.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/src/components/autocomplete/autocomplete.tsx
./node_modules/argo-ui/src/components/autocomplete/autocomplete.tsx
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/src/components/autocomplete/autocomplete.tsx(3,36)
      TS7016: Could not find a declaration file for module 'react-autocomplete'. '/Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/react-autocomplete/build/lib/Autocomplete.js' implicitly has an 'any' type.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/src/components/autocomplete/autocomplete.tsx
./node_modules/argo-ui/src/components/autocomplete/autocomplete.tsx
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/src/components/autocomplete/autocomplete.tsx(56,30)
      TS2349: This expression is not callable.
  Type 'typeof import("/Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/node_modules/classnames/index")' has no call signatures.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/src/components/autocomplete/autocomplete.tsx
./node_modules/argo-ui/src/components/autocomplete/autocomplete.tsx
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/src/components/autocomplete/autocomplete.tsx(109,34)
      TS7006: Parameter 'menuItems' implicitly has an 'any' type.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/src/components/autocomplete/autocomplete.tsx
./node_modules/argo-ui/src/components/autocomplete/autocomplete.tsx
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/src/components/autocomplete/autocomplete.tsx(109,45)
      TS7006: Parameter '_' implicitly has an 'any' type.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/src/components/autocomplete/autocomplete.tsx
./node_modules/argo-ui/src/components/autocomplete/autocomplete.tsx
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/src/components/autocomplete/autocomplete.tsx(109,48)
      TS7006: Parameter 'style' implicitly has an 'any' type.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/src/components/autocomplete/autocomplete.tsx
./node_modules/argo-ui/src/components/autocomplete/autocomplete.tsx
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/src/components/autocomplete/autocomplete.tsx(115,28)
      TS7006: Parameter 'item' implicitly has an 'any' type.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/src/components/autocomplete/autocomplete.tsx
./node_modules/argo-ui/src/components/autocomplete/autocomplete.tsx
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/src/components/autocomplete/autocomplete.tsx(118,26)
      TS7006: Parameter 'item' implicitly has an 'any' type.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/src/components/autocomplete/autocomplete.tsx
./node_modules/argo-ui/src/components/autocomplete/autocomplete.tsx
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/src/components/autocomplete/autocomplete.tsx(118,32)
      TS7006: Parameter 'isSelected' implicitly has an 'any' type.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/src/components/autocomplete/autocomplete.tsx
./node_modules/argo-ui/src/components/autocomplete/autocomplete.tsx
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/src/components/autocomplete/autocomplete.tsx(119,33)
      TS2349: This expression is not callable.
  Type 'typeof import("/Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/node_modules/classnames/index")' has no call signatures.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/src/components/autocomplete/autocomplete-field.tsx
./node_modules/argo-ui/src/components/autocomplete/autocomplete-field.tsx
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/src/components/autocomplete/autocomplete-field.tsx(3,28)
      TS7016: Could not find a declaration file for module 'react-form'. '/Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/react-form/dist/index.js' implicitly has an 'any' type.

ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/src/components/autocomplete/autocomplete-field.tsx
./node_modules/argo-ui/src/components/autocomplete/autocomplete-field.tsx
[tsl] ERROR in /Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/src/components/autocomplete/autocomplete-field.tsx(15,39)
      TS2349: This expression is not callable.
  Type 'typeof import("/Users/kkaizu/dev/src/github.com/argoproj/argo-workflows/ui/node_modules/argo-ui/node_modules/classnames/index")' has no call signatures.

UPDATE ➡️ #7598

Signed-off-by: krrrr38 <[email protected]>

krrrr38 · 2022-01-22T00:13:29Z

now works fine again.

alexec

LGTM

alexec · 2022-01-22T00:21:44Z

server/info/info_server_test.go

@@ -24,3 +25,31 @@ func Test_infoServer_GetUserInfo(t *testing.T) {
 		assert.Equal(t, "my-sa", info.ServiceAccountName)
 	}
 }
+
+func Test_infoServer_GetInfo(t *testing.T) {


Signed-off-by: krrrr38 <[email protected]>

krrrr38 · 2022-01-22T01:00:26Z

@alexec sorry, fixed golang-ci 😇 . CI succeeded.

Signed-off-by: krrrr38 <[email protected]>

krrrr38 mentioned this pull request Dec 12, 2021

feat: customize nav bar background color style argoproj/argo-ui#167

Merged

feat: customize nav bar background color

12bfc01

Signed-off-by: krrrr38 <[email protected]>

krrrr38 force-pushed the nav-bar-background-color branch from ffa27d7 to 12bfc01 Compare December 12, 2021 08:54

krrrr38 marked this pull request as ready for review December 12, 2021 08:59

krrrr38 requested review from alexec and jessesuen as code owners December 12, 2021 08:59

simster7 reviewed Dec 13, 2021

View reviewed changes

alexec reviewed Dec 13, 2021

View reviewed changes

alexec requested changes Dec 13, 2021

View reviewed changes

pkg/apis/workflow/v1alpha1/info.go Outdated Show resolved Hide resolved

alexec linked an issue Dec 13, 2021 that may be closed by this pull request

UI: make somewhat skinnable / themable #7054

Closed

feat: change Ui field as UI

2aaf743

Signed-off-by: krrrr38 <[email protected]>

alexec approved these changes Dec 14, 2021

View reviewed changes

alexec requested changes Dec 14, 2021

View reviewed changes

Merge branch 'master' into nav-bar-background-color

13bc89b

Signed-off-by: krrrr38 <[email protected]>

krrrr38 force-pushed the nav-bar-background-color branch from b96945a to 19d573a Compare December 14, 2021 01:49

krrrr38 force-pushed the nav-bar-background-color branch from 19d573a to ec09a5c Compare January 7, 2022 01:53

alexec approved these changes Jan 18, 2022

View reviewed changes

alexec requested changes Jan 18, 2022

View reviewed changes

feat: change nav bar color by config.navColor

6030c50

Signed-off-by: krrrr38 <[email protected]>

krrrr38 force-pushed the nav-bar-background-color branch from ec09a5c to 6030c50 Compare January 19, 2022 22:41

krrrr38 mentioned this pull request Jan 20, 2022

chore: upgrade argo-ui v2.5.0 #7598

Merged

Merge branch 'master' into nav-bar-background-color

6024f07

Signed-off-by: krrrr38 <[email protected]>

alexec approved these changes Jan 22, 2022

View reviewed changes

alexec enabled auto-merge (squash) January 22, 2022 00:22

auto-merge was automatically disabled January 22, 2022 00:32
Head branch was pushed to by a user without write access

krrrr38 force-pushed the nav-bar-background-color branch from 25a5994 to 6024f07 Compare January 22, 2022 00:32

chore: fix golang-lint

b3ceeeb

Signed-off-by: krrrr38 <[email protected]>

alexec merged commit 596f94c into argoproj:master Jan 24, 2022

yriveiro pushed a commit to yriveiro/argo-workflows that referenced this pull request Jan 27, 2022

feat: customize nav bar background color (argoproj#7387)

22acc5e

Signed-off-by: krrrr38 <[email protected]>

agilgur5 added area/ui area/server labels Oct 22, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: customize nav bar background color #7387

feat: customize nav bar background color #7387

krrrr38 commented Dec 12, 2021 •

edited

Loading

krrrr38 commented Dec 12, 2021 •

edited

Loading

simster7 Dec 13, 2021

krrrr38 Dec 14, 2021

alexec left a comment

alexec left a comment

krrrr38 commented Dec 14, 2021

krrrr38 commented Dec 14, 2021 •

edited

Loading

alexec left a comment

krrrr38 commented Jan 18, 2022

alexec commented Jan 19, 2022

krrrr38 commented Jan 19, 2022 •

edited

Loading

krrrr38 commented Jan 22, 2022

alexec left a comment

alexec Jan 22, 2022

krrrr38 commented Jan 22, 2022

feat: customize nav bar background color #7387

feat: customize nav bar background color #7387

Conversation

krrrr38 commented Dec 12, 2021 • edited Loading

Motivation

How to solve

Discussions

Check

krrrr38 commented Dec 12, 2021 • edited Loading

simster7 Dec 13, 2021

Choose a reason for hiding this comment

krrrr38 Dec 14, 2021

Choose a reason for hiding this comment

alexec left a comment

Choose a reason for hiding this comment

alexec left a comment

Choose a reason for hiding this comment

krrrr38 commented Dec 14, 2021

krrrr38 commented Dec 14, 2021 • edited Loading

alexec left a comment

Choose a reason for hiding this comment

krrrr38 commented Jan 18, 2022

alexec commented Jan 19, 2022

krrrr38 commented Jan 19, 2022 • edited Loading

krrrr38 commented Jan 22, 2022

alexec left a comment

Choose a reason for hiding this comment

alexec Jan 22, 2022

Choose a reason for hiding this comment

krrrr38 commented Jan 22, 2022

krrrr38 commented Dec 12, 2021 •

edited

Loading

krrrr38 commented Dec 12, 2021 •

edited

Loading

krrrr38 commented Dec 14, 2021 •

edited

Loading

krrrr38 commented Jan 19, 2022 •

edited

Loading