build!: update to golang 1.23 #733
Conversation
blkperl
added
dependencies
| @@ -1,6 +1,8 @@ | |||
| module github.com/argoproj/pkg | |||
|
|
|||
| go 1.14 | |||
| go 1.21 | |||
There was a problem hiding this comment.
Is it necessary to bump the minimum supported Go version here? I mentioned this in #707 (comment) that CI and local use is one thing, but this actually impacts consumers / is a breaking change
There was a problem hiding this comment.
I'm pretty sure go mod tidy did it for me. I can revert the change if you want.
There was a problem hiding this comment.
yea, even running make lint will update the go.mod file.
There was a problem hiding this comment.
CI fails without the go.mod update. I reverted the change
There was a problem hiding this comment.
That looks like because the toolchain config you added below requires Go 1.21+
There was a problem hiding this comment.
Well I didn't add it. golang automatically added it.
There was a problem hiding this comment.
Oh. Huh that was my first time seeing it and we don't have it in Workflows
I guess your newer version of Go will auto-add it? 🤔
Ironically you can't specify the 1.14 toolchain since that's older than 1.21
I'm fine with upgrading it, but since it will require consumers to have newer Go I'd prefer to avoid it if possible
There was a problem hiding this comment.
yeah, my local golang is 1.23 from homebrew.
Signed-off-by: william.vanhevelingen <[email protected]>
blkperl
force-pushed
the
update_golang_123
branch
from
e03d879
to
3fbe372
Compare
This comment was marked as resolved.
This comment was marked as resolved.
No description provided.