Ports Nova 263 (Nova forward port) #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p` method - Updated the function interface for generating `PublicParams` across several files, replacing the `new` method with `setup`. - The method name change impacts the `benches/recursive-snark-supernova.rs`, `src/supernova/test.rs`, and `src/supernova/mod.rs` files.
…me curve cycle (#263) * rename Group to Engine * port tests * checkpoint * checkpoint * compiles * update benchmarks and tests to use Engine * rename GroupExt to DlogGroup * move get_curve_params to Group and rename * fix doc test; cargo fmt * inline single trait requirements; fix comments * cut comment
huitseeker
force-pushed
the
port_nova
branch
from
a1c5d66
to
2d394ba
Compare
porcuquine
approved these changes
Nov 22, 2023
huitseeker
added a commit
to huitseeker/lurk-rs
that referenced
this pull request
Nov 22, 2023
…o#133 - Adapted the codebase to replace the `Group` types and traits with `Engine`, and replaced `G1` and `G2` with `E1` and `E2`. - Updated the trait `EvaluationEngineTrait<G>` and `RelaxedR1CSSNARKTrait` along with type aliases to reflect these changes. - Modified the `CurveCycleEquipped` implementation for `bn256::Scalar` and `pallas::Scalar`. - Made necessary adjustments to the aid functions and type aliases related to `NovaProver` for compatibility with the new group types. - Made changes in the SuperNova proving system to accommodate new `Engine` types.
|
Lurk companion PR: argumentcomputer/lurk-beta#917 |
huitseeker
added a commit
to huitseeker/lurk-rs
that referenced
this pull request
Nov 23, 2023
…o#133 - Adapted the codebase to replace the `Group` types and traits with `Engine`, and replaced `G1` and `G2` with `E1` and `E2`. - Updated the trait `EvaluationEngineTrait<G>` and `RelaxedR1CSSNARKTrait` along with type aliases to reflect these changes. - Modified the `CurveCycleEquipped` implementation for `bn256::Scalar` and `pallas::Scalar`. - Made necessary adjustments to the aid functions and type aliases related to `NovaProver` for compatibility with the new group types. - Made changes in the SuperNova proving system to accommodate new `Engine` types.
mpenciak
approved these changes
Nov 23, 2023
adr1anh
approved these changes
Nov 23, 2023
|
@huitseeker the companion PR is breaking on |
|
Nvm, you changed the arecibo branch there already |
github-merge-queue bot
pushed a commit
to argumentcomputer/lurk-beta
that referenced
this pull request
Nov 23, 2023
* refactor: Refactor to adpt to Arecibo changes argumentcomputer/arecibo#133 - Adapted the codebase to replace the `Group` types and traits with `Engine`, and replaced `G1` and `G2` with `E1` and `E2`. - Updated the trait `EvaluationEngineTrait<G>` and `RelaxedR1CSSNARKTrait` along with type aliases to reflect these changes. - Modified the `CurveCycleEquipped` implementation for `bn256::Scalar` and `pallas::Scalar`. - Made necessary adjustments to the aid functions and type aliases related to `NovaProver` for compatibility with the new group types. - Made changes in the SuperNova proving system to accommodate new `Engine` types. * chore: re-align the arecibo branch to dev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ports
microsoft/Nova#263
which refactors the traits using an
Enginetrait, which "mixes" the individual trait implementations required in Nova and pegs them on a token struct. This allows creating different combinations re-using some of the same modules.In simple terms, we can have several PCSes for a single curve cycle.
(The Lurk compilation breakage is expected)