Simplify ml evaluation testing (Nova Forward port, easy) #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huitseeker
force-pushed
the
simplify_ml_evaluation_testing
branch
from
1734132
to
4e538e1
Compare
huitseeker
changed the title
huitseeker
commented
Dec 18, 2023
| test_evaluation_with::<provider::bn256_grumpkin::bn256::Scalar>(); | ||
| test_evaluation_with::<provider::secp_secq::secp256k1::Scalar>(); | ||
| } | ||
|
|
||
| /// This evaluates a multilinear polynomial at a partial point in the evaluation domain, | ||
| /// which forces us to model how we pass coordinates to the evaluation function precisely. | ||
| fn partial_eval<F: PrimeField>( |
There was a problem hiding this comment.
This is bind_poly_var_top, with reverse endianness and a vectorised argument
mpenciak
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward ports small adjustments from microsoft/Nova#281