-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WANTED FEATURE] Update scripts
in setup.py
to entry_points
#365
Comments
scripts
in setup.py
to console_scripts
scripts
in setup.py
to entry_points
See Joe's Writeup linked below -- outlines all pieces that are required |
I described console script entry points in detail in this comment for MintPy, which may be helpful here. |
More notes after discussion with the team: It looks like the Things that might be worth doing along the way would be using setuptools_scm to get the version number from the git tags instead of the custom code in the setup.py And these should all be converted to actual console script entry-points: The
and then actually listing dependencies would be nice, as well as the supported python version |
You can use the asf-hyp3 pyproject.tomls as templates e.g. https://github.com/ASFHyP3/hyp3-lib/blob/develop/pyproject.toml A better starting point may be the cookiecutter template from the HyP3 folks: https://github.com/ASFHyP3/hyp3-cookiecutter/blob/develop/%7B%7Bcookiecutter.__project_name%7D%7D/pyproject.toml |
This is a more modern approach, but also will align with our conda-recipe.
See this example: https://github.com/insarlab/MintPy/blob/main/setup.py#L95-L162
Supposedly also helps with better cross platform compatability (read Windows) as indicated here: https://stackoverflow.com/a/28119736
The text was updated successfully, but these errors were encountered: