Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding ARIA-tools #22370

Merged
merged 17 commits into from
Jun 22, 2023
Merged

Adding ARIA-tools #22370

merged 17 commits into from
Jun 22, 2023

Conversation

dbekaert
Copy link
Contributor

@dbekaert dbekaert commented Mar 23, 2023 •
edited
Loading

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

dbekaert added 4 commits March 23, 2023 09:31
@dbekaert
Create meta.yaml
8bb7c6a 
setting up structure
@dbekaert
Update meta.yaml
b44ac30 
create meta yaml file
@dbekaert
Create build_base.sh
b213c92 
add build_base.sh script
@dbekaert
Merge branch 'conda-forge:main' into main
4bb8a25
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/ARIA-tools) and found some lint.

Here's what I've got...

For recipes/ARIA-tools:

  • about/license_family 'GNU' not allowed. Allowed families are AGPL,
    APACHE, BSD, CC, GPL, GPL2, GPL3, LGPL, MIT, MOZILLA, NONE, OTHER,
    PROPRIETARY, PSF, and PUBLIC-DOMAIN.
  • Recipe name has invalid characters. only lowercase alpha, numeric, underscores, hyphens and dots allowed

For recipes/ARIA-tools:

  • Recipes should usually depend on matplotlib-base as opposed to matplotlib so that runtime environments do not require large packages like qt.
  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@dbekaert
Copy link
Contributor Author

dbekaert commented Mar 23, 2023 •
edited
Loading

Could you confirm support to maintain the ARIA-tools conda channel? @sssangha @cmarshak @jhkennedy

@dbekaert
Copy link
Contributor Author

@jhkennedy any thoughts on the PR or changes?

dbekaert added 2 commits March 23, 2023 10:19
@dbekaert
Update meta.yaml
9ff3c9e 
Fix the license.
@dbekaert
Update meta.yaml
e928de6 
Fix comments from initial draft PR
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/ARIA-tools) and found it was in an excellent condition.

@jhkennedy
Copy link
Contributor

I'm happy to be a maintainer!

@cmarshak
Copy link
Contributor

I can be a maintainer

@sssangha
Copy link

I confirm my support to be a maintainer

jhkennedy
jhkennedy suggested changes Apr 4, 2023
View reviewed changes
recipes/ARIA-tools/meta.yaml Outdated Show resolved Hide resolved
recipes/ARIA-tools/meta.yaml Outdated Show resolved Hide resolved
dbekaert and others added 2 commits April 3, 2023 18:44
@dbekaert @jhkennedy
Update recipes/ARIA-tools/meta.yaml
bc48a1e 
Update version to match new release

Co-authored-by: Joseph H Kennedy <[email protected]>
@dbekaert @jhkennedy
Update recipes/ARIA-tools/meta.yaml
9e8ec21 
Update to point to new ariatools versiob

Co-authored-by: Joseph H Kennedy <[email protected]>
@dbekaert dbekaert marked this pull request as ready for review April 4, 2023 02:49
@cmarshak
Copy link
Contributor

@jhkennedy - do I need to review this?

@jhkennedy
Copy link
Contributor

@charliermarsh I believe @dbekaert needs to accept or reject my suggestions and then mark it ready for review by the conda-forge team

@dbekaert
Copy link
Contributor Author

@conda-forge/help-python ready for review 🚀

@dbekaert @jhkennedy
Update recipes/ARIA-tools/meta.yaml
149a280 
Remove the build case

Co-authored-by: Joseph H Kennedy <[email protected]>
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/ARIA-tools) and found some lint.

Here's what I've got...

For recipes/ARIA-tools:

  • requirements: run: gdal>=3.4.1 must contain a space between the name and the pin, i.e. gdal >=3.4.1
  • requirements: run: scipy<1.10 must contain a space between the name and the pin, i.e. scipy <1.10

jhkennedy
jhkennedy reviewed Apr 26, 2023
View reviewed changes
recipes/ARIA-tools/meta.yaml Outdated Show resolved Hide resolved
recipes/ARIA-tools/meta.yaml Outdated Show resolved Hide resolved
dbekaert and others added 2 commits April 26, 2023 11:09
@dbekaert @jhkennedy
Update recipes/ARIA-tools/meta.yaml
e40ef6d 
fix ScIpy space

Co-authored-by: Joseph H Kennedy <[email protected]>
@dbekaert @jhkennedy
Update recipes/ARIA-tools/meta.yaml
76773e7 
fix gdal space

Co-authored-by: Joseph H Kennedy <[email protected]>
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/ARIA-tools) and found some lint.

Here's what I've got...

For recipes/ARIA-tools:

  • requirements: run: gdal>=3.4.1 must contain a space between the name and the pin, i.e. gdal >=3.4.1

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/ARIA-tools) and found it was in an excellent condition.

@charliermarsh
Copy link
Contributor

I think I was accidentally tagged here, maybe intended to tag @cmarshak who has an extremely similar name 😂

@jhkennedy
Copy link
Contributor

Oh no, my bad @charliermarsh ! Sorry!

cmarshak
cmarshak reviewed Apr 26, 2023
View reviewed changes
recipes/ARIA-tools/meta.yaml Outdated

test:
imports:
- ARIA-tools
Copy link
Contributor

@cmarshak cmarshak Apr 26, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be ARIAtools

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I install, I can do something like from ARIAtools import ARIAProduct

@dbekaert @jhkennedy
Update recipes/ARIA-tools/meta.yaml
793fe27 
Fix for the import call

Co-authored-by: Joseph H Kennedy <[email protected]>
@dbekaert @cmarshak
Update recipes/ARIA-tools/meta.yaml
f6a9b26 
disable test imports, will figure out the secrets test seperately.

Co-authored-by: Charlie Marshak <[email protected]>
@cmarshak
Copy link
Contributor

cmarshak commented Jun 20, 2023 •
edited
Loading

@conda-forge/staged-recipes and/or @conda-forge/help-python this should be ready to merge!

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/ARIA-tools) and found some lint.

Here's what I've got...

For recipes/ARIA-tools:

  • The build section contained an unexpected subsection name. entrypoints is not a valid subsection name.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/ARIA-tools) and found it was in an excellent condition.

@cmarshak
Copy link
Contributor

cmarshak commented Jun 22, 2023 •
edited
Loading

@conda-forge/staged-recipes and/or @conda-forge/help-python: hoping this could be ready to merge even with improvements down the road.

ocefpaf
ocefpaf reviewed Jun 22, 2023
View reviewed changes
recipes/ARIA-tools/build_base.sh Outdated
@@ -0,0 +1,2 @@
export SETUPTOOLS_SCM_PRETEND_VERSION="$PKG_VERSION"
$PYTHON -m pip install . -vv
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need this file with the script line in the recipe.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am interpreting the comment as requesting to remove build.sh. Is that correct? Or should I remove one of the lines?

Thanks for your help with this.

@cmarshak
Delete build_base.sh
870fb60 
Remove build.sh
@ocefpaf ocefpaf merged commit 0a949b7 into conda-forge:main Jun 22, 2023
@cmarshak
Copy link
Contributor

Thank you @ocefpaf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhkennedy jhkennedy jhkennedy requested changes

@cmarshak cmarshak cmarshak left review comments

@ocefpaf ocefpaf ocefpaf left review comments

Assignees
No one assigned
Labels
python review-requested
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dbekaert @jhkennedy @cmarshak @sssangha @charliermarsh @ocefpaf