migration: remove warnings for remote_dir flow (#104)

* migration: remove version validate for remote_dir

* migration: only validate dev-url for local

* .github/workflows: restructure tests

* chore: try add test for dev-url

* chore: added test for no-version warning

* chore: added test for remote-dir

* chore: correct tests

.github/workflows/ci.yml

@@ -145,13 +145,32 @@ jobs:
         with:
           terraform_version: ${{ matrix.terraform-version }}
           terraform_wrapper: false
-      - name: Create local plugin
-        run: |
-          ./scripts/local.sh ./examples/testcase 0.0.0-pre.0
-      - name: Terraform
-        working-directory: examples/testcase
+      - name: Terraform (sqlite)
+        working-directory: integration-tests/sqlite
         run: |
+          ../../scripts/local.sh ../../dist 0.0.0-pre.0
           terraform init
           terraform apply --auto-approve
+      - name: Terraform (no-dev-url)
+        working-directory: integration-tests/no-dev-url
+        run: |
+          ../../scripts/local.sh ../../dist 0.0.0-pre.0
+          terraform init > /dev/null
+          terraform plan -no-color | grep --silent "Warning: dev_url is unset"
+      - name: Terraform (no-version)
+        working-directory: integration-tests/no-version
+        run: |
+          ../../scripts/local.sh ../../dist 0.0.0-pre.0
+          terraform init > /dev/null
+          terraform plan -no-color | grep --silent "Warning: version is unset"
+      - name: Terraform (remote_dir)
+        working-directory: integration-tests/remote-dir
+        run: |
+          ../../scripts/local.sh ../../dist 0.0.0-pre.0
+          terraform init > /dev/null
+          terraform plan -no-color > stdout.txt
+          cat stdout.txt | grep --silent "Plan: 1 to add, 0 to change, 0 to destroy."
+          ! cat stdout.txt | grep --silent "Warning: dev_url is unset"
+          ! cat stdout.txt | grep --silent "Warning: version is unset"
         env:
-          TF_LOG: DEBUG
+          TF_VAR_atlas_token: ${{ secrets.ATLAS_TOKEN }}

integration-tests/.gitignore

@@ -0,0 +1,5 @@
+**/.terraform.lock.hcl
+**/.terraform/*
+**/terraform.d
+**/*.db
+**/stdout.txt

integration-tests/no-dev-url/main.tf

@@ -0,0 +1,18 @@
+terraform {
+  required_providers {
+    atlas = {
+      source  = "ariga/atlas"
+      version = "0.0.0-pre.0"
+    }
+  }
+}
+
+data "atlas_schema" "db" {
+  src     = "file://schema.sql"
+  dev_url = "sqlite://file?mode=memory"
+}
+
+resource "atlas_schema" "db" {
+  hcl = data.atlas_schema.db.hcl
+  url = "sqlite://file.db"
+}

integration-tests/no-version/main.tf

@@ -0,0 +1,19 @@
+terraform {
+  required_providers {
+    atlas = {
+      source  = "ariga/atlas"
+      version = "0.0.0-pre.0"
+    }
+  }
+}
+
+data "atlas_migration" "db" {
+  dir = "./migrations"
+  url = "sqlite://file.db"
+}
+
+resource "atlas_migration" "db" {
+  dir     = "./migrations"
+  url     = "sqlite://file.db"
+  dev_url = "sqlite://file?mode=memory"
+}

integration-tests/no-version/migrations/20231120145001.sql

@@ -0,0 +1,6 @@
+CREATE TABLE t1 (
+  c1 INT,
+  c2 TEXT,
+  PRIMARY KEY (c1)
+);
+

integration-tests/no-version/migrations/20231120145012.sql

@@ -0,0 +1,6 @@
+CREATE TABLE t2 (
+  c1 INT,
+  c2 TEXT,
+  PRIMARY KEY (c1)
+);
+

integration-tests/no-version/migrations/atlas.sum

@@ -0,0 +1,3 @@
+h1:dy0koXujpoUhVPowi2KP9Qoq0Sr6trcEmvrVWWXnN24=
+20231120145001.sql h1:08Mdpo805VLOztN/C3vpi/pIyDjMCGFHfA/pmhtcgJI=
+20231120145012.sql h1:h1DU3vLKHhhV6ilw6+DQ1plbVpRXQxZi4PYDgDmRDZs=

integration-tests/remote-dir/main.tf

@@ -0,0 +1,33 @@
+terraform {
+  required_providers {
+    atlas = {
+      source  = "ariga/atlas"
+      version = "0.0.0-pre.0"
+    }
+  }
+}
+
+variable "atlas_token" {
+  type      = string
+  sensitive = true
+}
+
+provider "atlas" {
+  cloud {
+    token = var.atlas_token
+  }
+}
+
+data "atlas_migration" "db" {
+  url = "sqlite://file.db"
+  remote_dir {
+    name = "tf-remote-dir"
+  }
+}
+
+resource "atlas_migration" "db" {
+  url = "sqlite://file.db"
+  remote_dir {
+    name = "tf-remote-dir"
+  }
+}

integration-tests/sqlite/schema.sql

@@ -0,0 +1,5 @@
+CREATE TABLE t1 (
+  c1 INT,
+  c2 TEXT,
+  PRIMARY KEY (c1)
+);

internal/provider/atlas_migration_resource.go

@@ -211,9 +211,12 @@ func (r MigrationResource) ValidateConfig(ctx context.Context, req resource.Vali
 	if resp.Diagnostics.HasError() {
 		return
 	}
-	resp.Diagnostics.Append(r.validateConfig(ctx, req.Config)...)
-	if resp.Diagnostics.HasError() {
-		return
+	if data.RemoteDir == nil {
+		// Local dir, validate config for dev-url
+		resp.Diagnostics.Append(r.validateConfig(ctx, req.Config)...)
+		if resp.Diagnostics.HasError() {
+			return
+		}
 	}
 	// Validate the remote_dir block
 	switch {
@@ -240,6 +243,7 @@ func (r MigrationResource) ValidateConfig(ctx context.Context, req resource.Vali
 			)
 			return
 		}
+		return
 	case data.DirURL.IsNull():
 		resp.Diagnostics.AddError(
 			"dir is unset",

scripts/local.sh

@@ -8,6 +8,6 @@ TARGET=$(go env GOOS)_$(go env GOARCH)
 PACKED="terraform-provider-${TYPE}_${VERSION}_${TARGET}.zip"
 
 PLUGIN_ADDR="${HOSTNAME}/${NAMESPACE}/${TYPE}"
-PLUGIN_PATH="${1}/terraform.d/plugins/${PLUGIN_ADDR}"
+PLUGIN_PATH="./terraform.d/plugins/${PLUGIN_ADDR}"
 mkdir -p $PLUGIN_PATH
-cp ./dist/${PACKED} $PLUGIN_PATH
+cp ${1}/${PACKED} $PLUGIN_PATH