atlas/migration: support custom env_name on datasource #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giautm
changed the title
giautm
force-pushed
the
g/v0.9.1-patch
branch
from
c28f576 to
85de4e7
Compare
giautm
force-pushed
the
g/v0.9.1-patch
branch
2 times, most recently
from
2ce2024 to
63597d7
Compare
giautm
force-pushed
the
g/v0.9.1-patch
branch
from
63597d7 to
da3d1ba
Compare
a8m
reviewed
Sep 15, 2024
| @@ -27,6 +27,7 @@ data "atlas_migration" "hello" { | |||
| - `cloud` (Block, Optional) (see [below for nested schema](#nestedblock--cloud)) | |||
| - `config` (String) The configuration file for the migration | |||
| - `dir` (String) Select migration directory using URL format | |||
| - `env_name` (String) The name of the environment used for reporting runs to Atlas Cloud. Default: tf | |||
There was a problem hiding this comment.
Suggested change
| - `env_name` (String) The name of the environment used for reporting runs to Atlas Cloud. Default: tf | |
| - `env_name` (String, Optional) The name of the environment used for reporting runs to Atlas Cloud. Default: tf |
It’s optional, right?
There was a problem hiding this comment.
It's listing under the optional attributes list, ;)
a8m
approved these changes
Sep 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
atlas.envfrom the generated config