Fixes isaacs#233 (processing instruction ending with "?")

Recognizes "?" while in the PROC_INST_ENDING state, and keeps it in that state after adding "?" to the body
arista · May 15, 2018 · 8a00e75 · 8a00e75
1 parent 5aee216
commit 8a00e75
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/lib/sax.js b/lib/sax.js
@@ -1263,6 +1263,8 @@
             })
             parser.procInstName = parser.procInstBody = ''
             parser.state = S.TEXT
+          } else if (c === '?') {
+            parser.procInstBody += '?'
           } else {
             parser.procInstBody += '?' + c
             parser.state = S.PROC_INST_BODY

diff --git a/test/issue-233.js b/test/issue-233.js
@@ -0,0 +1,9 @@
+require(__dirname).test({
+  xml: '<r><?Is this legal XML??></r>',
+  expect: [
+    ['opentagstart', {'name': 'R', 'attributes': {}}],
+    ['opentag', {'name': 'R', 'attributes': {}, 'isSelfClosing': false}],
+    [ 'processinginstruction', { name: 'Is', body: 'this legal XML?' } ],
+    ['closetag', 'R']
+  ]
+})