Move all TODOs and FIXMEs to GitHub issues #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
priv/static/assets/js/arizona.js
Outdated
| @@ -34,11 +34,9 @@ globalThis["arizona"] = (() => { | |||
| const subscribers = new Map() | |||
| const unsubscribers = new Map() | |||
|
|
|||
| // @todo Subscribe to global events. | |||
priv/static/assets/js/arizona.js
Outdated
| function subscribe(eventName, callback, opts = {}) { | ||
| let eventSubs = subscribers.get(eventName) | ||
| if (!eventSubs) eventSubs = new Map() | ||
| // @todo Improve id. |
| @@ -31,7 +31,6 @@ HTML support. | |||
| %% API funtions. | |||
| %% -------------------------------------------------------------------- | |||
|
|
|||
| % TODO: Do this really safe for HTML. | |||
| @@ -42,7 +42,6 @@ send(Event, Payload) -> | |||
| %% Internal funtions. | |||
| %% -------------------------------------------------------------------- | |||
|
|
|||
| % TODO: Real safe JS. | |||
| @@ -96,7 +96,6 @@ handle_info({_Pid, {fs, file_event}, {File, Events}}, | |||
| [modified, closed] -> | |||
| {noreply, State#state{files = Files#{File => {erl, modified}}}}; | |||
| _ -> | |||
| % TODO: Act on created, renamed, deleted. | |||
Comment on lines
-77
to
-81
| % TODO: Rename 'arz-id' to 'arz-sid' (statefull id), | ||
| % and provide a 'arz-tid' (tag id) to each tag. | ||
| % I think this can improve changes patch, | ||
| % because just the most close tag could be rendered | ||
| % instead of the entirely block/tree. |
| @@ -285,7 +274,6 @@ block_struct(Block, P, I, State) -> | |||
| vars => vars_group(vars(ExprVars, Id)) | |||
| }. | |||
|
|
|||
| % TODO: Change to binary_to_existing_atom. | |||
| @@ -311,7 +299,6 @@ find_first_tag(_) -> | |||
| is_tag(Name) -> | |||
| not lists:member(Name, [<<"!DOCTYPE">>, <<"!doctype">>, <<"?xml">>]). | |||
|
|
|||
| % TODO: Use binary_to_existing_atom. | |||
Comment on lines
-600
to
-602
| {% FIXME: This implementation wont work, because it } | ||
| {% needs to be compiled in tokens. } | ||
| {% The 'merl:tsubst' should be used to fix this. } |
| @@ -94,7 +94,6 @@ do_parse_tag([tag_close | T0], Props0, Macros) -> | |||
| true -> | |||
| Props = case OpenName =:= <<"head">> of | |||
| true -> | |||
| % TODO: Do not reverse. | |||
| @@ -163,12 +162,10 @@ parse_attr(K, {expr, ExprStr}, Macros) -> | |||
| parse_attr(K, {text, Text}, _Macros) -> | |||
| do_parse_attr(K, {text, Text}). | |||
|
|
|||
| % TODO: Directive keys to atom using binary_to_existing_atom. | |||
Comment on lines
-33
to
-48
| % TODO: Implement the :case directive: | ||
| % """ | ||
| % {% The directive should be a valid Erlang syntax, like: } | ||
| % {:case _@foo of | ||
| % foo -> | ||
| % """ | ||
| % {% Expressions will be compiled into a tree... } | ||
| % <div>foo</div> | ||
| % """; | ||
| % Bar -> | ||
| % """ | ||
| % {% and should be able to eval variables. } | ||
| % <div>{Bar}</div> | ||
| % """ | ||
| % end} | ||
| % """. |
| string(Str) when is_binary(Str) -> | ||
| % TODO: Location. |
Comment on lines
-123
to
-124
| % FIXME: If closing_tag we should go to 'scan' | ||
| % instead of 'scan_attr_key'. |
| @@ -71,7 +71,6 @@ websocket_handle({text, Msg}, #{sockets := Sockets} = State) -> | |||
| {Target, Event, Payload} = decode_msg(Msg), | |||
| Socket0 = maps:get(Target, Sockets), | |||
| View = maps:get(view, Socket0), | |||
| % TODO: {reply, Msg, Socket} | |||
williamthome
previously approved these changes
Jun 29, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
paulo-ferraz-oliveira
force-pushed
the
fix/todos-and-fixmes
branch
from
7a436c2 to
2969d7f
Compare
| @@ -35,11 +35,9 @@ globalThis["arizona"] = (() => { | |||
| const subscribers = new Map(); | |||
| const unsubscribers = new Map(); | |||
|
|
|||
| // @todo Subscribe to global events. | |||
| function subscribe(eventName, callback, opts = {}) { | ||
| let eventSubs = subscribers.get(eventName); | ||
| if (!eventSubs) eventSubs = new Map(); | ||
| // @todo Improve id. |
williamthome
approved these changes
Jun 29, 2024
|
I'm gonna un-resolve all comments since this is now merge. It'll make it easier to come back here for backtracking what originated an issue. Edit: ... and then we can resolve them as we go along, though that's not a strict requirement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #63.
Further considerations
Self-review will show references from each change to a created issue.