-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Second attempt at CryoPod Creature addition #15
base: master
Are you sure you want to change the base?
Conversation
…h local functions to promote scope; remove redundant dispose calls; though a future concept in respect to parallel or concurrent support, ensure each temporary file is uniquely named (and provided by the system) in the scope of this iteration.
ArkSavegameToolkitNet/ArkSaveGame.cs
Outdated
Objects.Add(dino); | ||
Objects.Add(statusobject); | ||
|
||
cryoVa.Dispose(); |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed and approve these code changes; I have not tested or can not determine whether the feature should be added
There are some general refactor suggestions I have, and in fact started some code changes based on your commits here that I will PR to this source branch for your consideration. it's not a blocker to this PR though, I could always PR the additional code changes to this repo at some later point.
FYI, you don't need to abandon\close PRs, they reflect the history of changes and review\comments are point in time.
Suggested Refactoring
Just a heads up, if you read in another GameObject after the status object, you get the inventory object. I know items are dropped when they're in cryopods, but I'm not sure if it shows any saddle that's attached |
Different named/casing of some properties, new properties added. Genesis map image and map co-ordinates added.
2nd attempt at a pull request following review by brcaswell.
Various changes based on his recommendations against my last failed PR.